Closed Bug 1906975 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 47064 - Rename invokeaction->command, invoketarget->commandfor

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47064 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47064
Details from upstream follow.

Keith Cirkel <chromium@keithcirkel.co.uk> wrote:

Rename invokeaction->command, invoketarget->commandfor

This also drops the "auto" value, and updates all tests to accommodate
these changes, as well as adding more tests for extra robustness.

This is the result of a discussion around renaming the attribute which starts around https://github.com/whatwg/html/issues/9625#issuecomment-2140717681 and concludes in https://github.com/whatwg/html/issues/9625#issuecomment-2181099405.

Bug: 349994204
Change-Id: Ic4a5572506e855036c8c1f75aa0de894de026948
Reviewed-on: https://chromium-review.googlesource.com/5666705
WPT-Export-Revision: cf312ecfe8e8e8bde51fa226936d646714a8f86d

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 16 tests and 12 subtests

Status Summary

Firefox

OK : 16
PASS: 156
FAIL: 138

Chrome

OK : 16
PASS: 156
FAIL: 138

Safari

OK : 16
PASS: 157
FAIL: 137

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/invokers/idlharness.tentative.html [wpt.fyi]
    • CommandEvent interface: existence and properties of interface object: FAIL (Chrome: FAIL, Safari: FAIL)
    • CommandEvent interface object length: FAIL (Chrome: FAIL, Safari: FAIL)
    • CommandEvent interface object name: FAIL (Chrome: FAIL, Safari: FAIL)
    • CommandEvent interface: existence and properties of interface prototype object: FAIL (Chrome: FAIL, Safari: FAIL)
    • CommandEvent interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: FAIL, Safari: FAIL)
    • CommandEvent interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: FAIL, Safari: FAIL)
    • CommandEvent interface: attribute invoker: FAIL (Chrome: FAIL, Safari: FAIL)
    • CommandEvent interface: attribute command: FAIL (Chrome: FAIL, Safari: FAIL)
    • CommandEvent must be primary interface of new CommandEvent("invoke"): FAIL (Chrome: FAIL, Safari: FAIL)
    • Stringification of new CommandEvent("invoke"): FAIL (Chrome: FAIL, Safari: FAIL)
    • CommandEvent interface: new CommandEvent("invoke") must inherit property "invoker" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
    • CommandEvent interface: new CommandEvent("invoke") must inherit property "command" with the proper type: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/invokers/invokeelement-interface.tentative.html [wpt.fyi]
    • commandForElement reflects invokee HTML element: FAIL (Chrome: FAIL, Safari: FAIL)
    • commandForElement reflects set value: FAIL (Chrome: FAIL, Safari: FAIL)
    • commandForElement reflects set value across shadow root into light dom: FAIL (Chrome: FAIL, Safari: FAIL)
    • commandForElement does not reflect set value inside shadowroot: FAIL (Chrome: FAIL, Safari: FAIL)
    • commandForElement throws error on assignment of non Element: FAIL (Chrome: FAIL, Safari: FAIL)
    • command reflects '' when attribute empty, setAttribute version: FAIL (Chrome: FAIL, Safari: FAIL)
    • command reflects same casing: FAIL (Chrome: FAIL, Safari: FAIL)
    • command reflects tostring value: FAIL (Chrome: FAIL, Safari: FAIL)
    • command reflects '' when attribute set to []: FAIL (Chrome: FAIL, Safari: FAIL)
    • command reflects tostring value 2: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/invokers/invokeevent-dispatch-shadow.tentative.html [wpt.fyi]
    • CommandEvent propagates across shadow boundaries retargeting invoker: FAIL (Chrome: FAIL, Safari: FAIL)
    • cross shadow CommandEvent retargets invoker to host element: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/invokers/invokeevent-interface.tentative.html [wpt.fyi]
    • command is a readonly defaulting to '': FAIL (Chrome: FAIL, Safari: FAIL)
    • invoker is readonly defaulting to null: FAIL (Chrome: FAIL, Safari: FAIL)
    • command reflects initialized attribute: FAIL (Chrome: FAIL, Safari: FAIL)
    • command set to undefined: FAIL (Chrome: FAIL, Safari: FAIL)
    • command set to null: FAIL (Chrome: FAIL, Safari: FAIL)
    • command set to false: FAIL (Chrome: FAIL, Safari: FAIL)
    • command explicitly set to empty string: FAIL (Chrome: FAIL, Safari: FAIL)
    • command set to true: FAIL (Chrome: FAIL, Safari: FAIL)
    • command set to a number: FAIL (Chrome: FAIL, Safari: FAIL)
    • command set to []: FAIL (Chrome: FAIL, Safari: FAIL)
    • command set to [1, 2, 3]: FAIL (Chrome: FAIL, Safari: FAIL)
    • command set to an object: FAIL (Chrome: FAIL, Safari: FAIL)
    • command set to an object with a toString function: FAIL (Chrome: FAIL, Safari: FAIL)
    • CommandEventInit properties set value: FAIL (Chrome: FAIL, Safari: FAIL)
    • CommandEventInit properties set value 2: FAIL (Chrome: FAIL, Safari: FAIL)
    • CommandEventInit properties set value 3: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoker set to undefined: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoker set to null: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoker set to false: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoker set to true: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoker set to {}: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoker set to non-Element EventTarget: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html [wpt.fyi]
    • event dispatches on click: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command property to -foo (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command attribute to -foo (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command property to foo- (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command attribute to foo- (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command property to cAsE-cArRiEs (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command attribute to cAsE-cArRiEs (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command property to - (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command attribute to - (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command property to -a- (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command attribute to -a- (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command property to a-b (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command attribute to a-b (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command property to --- (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command attribute to --- (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command property to show-picker (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • setting custom command attribute to show-picker (must include dash) sets event command: FAIL (Chrome: FAIL, Safari: FAIL)
    • event dispatches if invoker is form associated with type=button: FAIL (Chrome: FAIL, Safari: FAIL)
    • event dispatches if invokee is non-HTML Element: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-fullscreen-behavior.tentative.html [wpt.fyi]
    • invoking div with toggleFullscreen action makes div fullscreen: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking fullscreen div with toggleFullscreen action exits fullscreen: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking fullscreen div with toggleFullscreen (case-insensitive) action exits fullscreen: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking div with requestFullscreen action makes div fullscreen: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking fullscreen div with exitFullscreen action exits fullscreen: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-on-audio-behavior.tentative.html [wpt.fyi]
    • invoking audio with playpause action makes audio play: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking audio with playpause action (without user activation) is a no-op: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking playing audio with playpause action pauses it: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking audio with play action makes audio play: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking audio with play action (without user activation) is a no-op: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking playing audio with pause action makes it pause: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking audio with toggleMuted action mutes it: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking muted audio with toggleMuted action unmutes it: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-on-details-behavior.tentative.html [wpt.fyi]
    • invoking (as toggle) closed details opens: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as open) closed details opens: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as tOgGlE) closed details opens: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as oPeN) closed details opens: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as toggle) open details closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as close) open details closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as tOgGlE) open details closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as cLoSe) open details closes: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-on-dialog-behavior.tentative.html [wpt.fyi]
    • invoking (with command property as showmodal) closed dialog opens as modal: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (with command property as showmodal) while changing command still opens as modal: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (with command attribute as showmodal) closed dialog opens as modal: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (with command attribute as showmodal) while changing command still opens as modal: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (with command property as sHoWmOdAl) closed dialog opens as modal: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (with command property as sHoWmOdAl) while changing command still opens as modal: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (with command attribute as sHoWmOdAl) closed dialog opens as modal: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (with command attribute as sHoWmOdAl) while changing command still opens as modal: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking to close (with command property as close) open dialog closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking to close (with command property as close) open dialog while changing command still closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking to close (with command property as close) open modal dialog while changing command still closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking to close (with command attribute as close) open dialog closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking to close (with command attribute as close) open dialog while changing command still closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking to close (with command attribute as close) open modal dialog while changing command still closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking to close (with command property as cLoSe) open dialog closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking to close (with command property as cLoSe) open dialog while changing command still closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking to close (with command property as cLoSe) open modal dialog while changing command still closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking to close (with command attribute as cLoSe) open dialog closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking to close (with command attribute as cLoSe) open dialog while changing command still closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking to close (with command attribute as cLoSe) open modal dialog while changing command still closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as showmodal) closed popover dialog opens as modal: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-on-input-number.tentative.html [wpt.fyi]
    • invoking number input with stepup action increments value: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking number input with stepup action (case-insensitive) increments value: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking number input with stepdown action decrements value: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking number input with stepdown action (case-insensitive) decrements value: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-on-popover-behavior.tentative.html [wpt.fyi]
    • changing command attribute inside invokeevent doesn't impact the invocation: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as togglepopover) closed popover opens: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as showpopover) closed popover opens: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as tOgGlEpOpOvEr) closed popover opens: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as sHoWpOpOvEr) closed popover opens: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as togglepopover) open popover with preventDefault does not close: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as togglepopover) from within open popover closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as hidepopover) open popover with preventDefault does not close: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as hidepopover) from within open popover closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as tOgGlEpOpOvEr) open popover with preventDefault does not close: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as tOgGlEpOpOvEr) from within open popover closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as hIdEpOpOvEr) open popover with preventDefault does not close: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as hIdEpOpOvEr) from within open popover closes: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as showpopover) open popover is noop: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-on-popover-invalid-behavior.tentative.html [wpt.fyi]
    • invoking (as null) on open popover does nothing: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as ) on open popover does nothing: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as foo-bar) on open popover does nothing: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as showmodal) on open popover does nothing: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as showpicker) on open popover does nothing: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as open) on open popover does nothing: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking (as close) on open popover does nothing: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-on-video-behavior.tentative.html [wpt.fyi]
    • invoking video with playpause action makes video play: FAIL (Chrome: FAIL, Safari: PASS)
    • invoking playing video with playpause action pauses it: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking video with play action makes video play: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking playing video with pause action makes it pause: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking video with toggleMuted action mutes it: FAIL (Chrome: FAIL, Safari: FAIL)
    • invoking muted video with toggleMuted action unmutes it: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f9b3e738127 [wpt PR 47064] - Rename invokeaction->command, invoketarget->commandfor, a=testonly https://hg.mozilla.org/integration/autoland/rev/d656df1efadf [wpt PR 47064] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/0f9b3e738127
https://hg.mozilla.org/mozilla-central/rev/d656df1efadf

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox130: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.