Closed Bug 1907094 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 47073 - Fix crash in moveBefore

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47073 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47073
Details from upstream follow.

Noam Rosenthal <nrosenthal@chromium.org> wrote:

Fix crash in moveBefore

This crash was created because when we move inputs around some of their
(shadow) descendants are text fragments, and FlatTreeParentChanged
doesn't like that. Made it so that FlatTreeParentChanged only works on
elements/text nodes.

Bug: 352081025
Change-Id: Ied34f1e66817fde8625b56dbbf2ed05e62eb68bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5691651
Reviewed-by: Dominic Farolino \<dom@chromium.org>
Commit-Queue: Noam Rosenthal \<nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1325460}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/caede93b9e9c [wpt PR 47073] - Fix crash in moveBefore, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.