1907132 - EnqueuePromiseResolveThenableJob allocates an array object unnecessarily

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Jon Coppeard (:jonco)]

This is pretty minor, but while reading this code I noticed that EnqueuePromiseResolveThenableJob creates an array object to hold arguments for PromiseResolveThenableJob. However there are enough slots in extended function object to store the arguments there already without allocating an extra object.

This does not apply to EnqueuePromiseResolveThenableBuiltinJob which I assume will get called a lot more often.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1907132 - Store arguments to PromiseResolveThenableJob in the extended function object

Currently EnqueuePromiseResolveThenableJob allocates an array for this but
there are enough slots in an extended function to store all the arguments
there.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e9a93d104d2
Store arguments to PromiseResolveThenableJob in the extended function object r=spidermonkey-reviewers,arai,mgaudet

Comment 3

[Cristian Tuns]

Backed out for causing spidermonkey bustages in Promise.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/js/src/builtin/Promise.cpp:134:58: error: comparison between 'enum ThenableJobSlots' and 'enum js::FunctionExtended::<unnamed>' [-Werror=enum-compare]

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0045cbfc8dbe
Store arguments to PromiseResolveThenableJob in the extended function object r=spidermonkey-reviewers,arai,mgaudet

Comment 5

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/0045cbfc8dbe