1907190 - Fix testBrokenApp() to handle logs with async stacks.

Status: RESOLVED FIXED

(WebExtensions :: General, task, P3)

Description

[Mark Hammond [:markh] [:mhammond]]

Bug 1904975 introduced async stacks for xpcshell tests, but test_ext_native_messaging.js has a few assumptions about the stacks which don't work correctly. That bug landed a work-around in that test - this bug is to remove that workaround.

Comment 1

[Rob Wu [:robwu]]

I'll take a quick look to see if there is anything obvious.

This is about the tests at https://searchfox.org/mozilla-central/rev/54a5c4f14f3eb514a29e0cebcb5a095144bcd450/toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js#457-486,738-754

Comment 2

[Rob Wu [:robwu]]

The issue happens because with longer async stacks, the m.message values of identical errors are no longer identical, due to the different call sites. Consequently, the logic that de-duplicates errors does not work, at https://searchfox.org/mozilla-central/rev/54a5c4f14f3eb514a29e0cebcb5a095144bcd450/toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js#391-396

To fix this, we could use m.errorMessage instead of m.message.

Another alternative is to duplicate the expectation. I'm going to do this, so that every error is explicitly accounted for.

Comment 3

[Rob Wu [:robwu]]

When I fixed the underlying issue by requiring every error message to be accounted for, a new duplicate test failure appeared because there was another source of a duplicate message.

I fixed that and attached the patch to bug 1908201, which will have to land before the patch to this bug.

Comment 4

[Rob Wu [:robwu]]

Attachment: Bug 1907190 - Fix test expectations for duplicate error messages

As explained at https://bugzilla.mozilla.org/show_bug.cgi?id=1907190#c2

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e05038eefbf
Fix test expectations for duplicate error messages r=willdurand

Comment 6

[tszentpeteri]

Backed out for causing xpcshell failures on test_ext_native_messaging.js

• Backout link
• Push with failures
• Failure Log:

[task 2024-07-16T23:51:24.534Z] 23:51:24     INFO -  TEST-START | toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js
[task 2024-07-16T23:56:24.537Z] 23:56:24  WARNING -  TEST-UNEXPECTED-TIMEOUT | toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js | Test timed out
[task 2024-07-16T23:56:24.537Z] 23:56:24     INFO -  TEST-INFO took 300004ms
[task 2024-07-16T23:56:24.538Z] 23:56:24     INFO -  >>>>>>>
[task 2024-07-16T23:56:24.538Z] 23:56:24     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-07-16T23:56:24.539Z] 23:56:24     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2024-07-16T23:56:24.539Z] 23:56:24     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2024-07-16T23:56:24.539Z] 23:56:24     INFO -  running event loop
[task 2024-07-16T23:56:24.539Z] 23:56:24     INFO -  toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js | Starting setup check_remote
[task 2024-07-16T23:56:24.540Z] 23:56:24     INFO -  (xpcshell/head.js) | test check_remote pending (2)
[task 2024-07-16T23:56:24.540Z] 23:56:24     INFO -  TEST-PASS | toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js | check_remote - [check_remote : 1] useRemoteWebExtensions matches - false == false

Comment 7

[Rob Wu [:robwu]]

Was an issue with the patch in bug 1908201; will fix and reland.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44210ec80d0d
Fix test expectations for duplicate error messages r=willdurand

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/44210ec80d0d