Closed Bug 1907233 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 47086 - Geolocation: fix flaky test

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox130 fixed)

RESOLVED FIXED
130 Branch
Tracking Status
firefox130 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47086 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47086
Details from upstream follow.

Marcos Caceres <caceres_m@apple.com> wrote:

Geolocation: fix flaky test

Because this test was calling navigator.geolocation.getCurrentPosition, a cached position was being generated before the timeout/maxAge tests were being run.. then meant that cached position could suddenly appear and get returned, leading to flaky tests in "webkit 1".

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
PASS : 4
FAIL : 2

Chrome

OK : 1
PASS : 6

Safari

ERROR : 1
NOTRUN: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /geolocation/PositionOptions.https.html [wpt.fyi]
    • Set timeout and maximumAge to 0, check that timeout error raised (watchPosition): FAIL (Chrome: PASS, Safari: NOTRUN)
    • Check that a negative timeout and maxAge values are clamped to 0 (watchPosition): FAIL (Chrome: PASS, Safari: NOTRUN)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0787152f9ed6 [wpt PR 47086] - Geolocation: fix flaky test, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.