1907539 - Make nsNetworkLinkService::calculateNetworkIdWithDelay shutdown aware

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Jens Stutte [:jstutte]]

6dd015ad-8cf8-4cd1-8003-f28ff0240710 a StreamTrans thread is stuck inside the nsNetworkLinkService in calculateNetworkIdInternal. There could be a chance that by the time that the runnable executes the network has gone away for system shutdown and we are waiting for some looong timeout from the system?

Comment 1

[Jens Stutte [:jstutte]]

It might help to just add a AppShutdown::IsInOrBeyond check right at the beginning of calculateNetworkIdWithDelay. It is not 100% clear to me, which would be an appropriate phase, maybe AppShutdownNetTeardown ?

Comment 2

[Kershaw Chang [:kershaw]]

(In reply to Jens Stutte [:jstutte] from comment #1)

It might help to just add a AppShutdown::IsInOrBeyond check right at the beginning of calculateNetworkIdWithDelay. It is not 100% clear to me, which would be an appropriate phase, maybe AppShutdownNetTeardown ?

Thanks for filing this bug.
Yes, AppShutdownNetTeardown sounds correct to me. I'll submit a patch soon.

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1907539 - Don't calculate network ID during shutdown, r=#necko

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5c3f0f3c83d
Don't calculate network ID during shutdown, r=acreskey

Comment 5

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/c5c3f0f3c83d