Closed
Bug 190755
Opened 22 years ago
Closed 22 years ago
typeahead find crashes when backspacing
Categories
(SeaMonkey :: Find In Page, defect)
SeaMonkey
Find In Page
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: ajschult784, Assigned: aaronlev)
References
()
Details
(Keywords: crash, regression)
Attachments
(2 files)
8.22 KB,
text/plain
|
Details | |
847 bytes,
patch
|
timeless
:
review+
jst
:
superreview+
dbaron
:
approval1.3b+
|
Details | Diff | Splinter Review |
With linux trunk build 2003012522 typeahead find crashes when backspacing. The crash only occurs with the new "Find automatically when typing within a web page" pref disabled. Steps to reproduce: 1. Disable automatic find (advanced->keyboard nav) 2. load http://www.mozilla.org/ 3. type "/bug" 4. hit backspace 3 times after the 3rd backspace, Mozilla crashes before clearing the typeahead buffer. This crash happens with builds from right after the pref was enabled.
Reporter | ||
Comment 1•22 years ago
|
||
(gdb) frame 7 #7 0x40b75a1a in nsTypeAheadFind::HandleBackspace() (this=0x812e4f0) at nsTypeAheadFind.cpp:733 733 mFocusedDocSelection->AddRange(mStartFindRange); (gdb) p mStartFindRange $1 = {mRawPtr = 0x0} (gdb) p mFocusedDocSelection $2 = {mRawPtr = 0x0}
Comment 2•22 years ago
|
||
i see this too. occurs with 2003.01.27 trunk bits on linux rh7.2 and mac on 10.2.3. looks like this regressed sometime btwn 2003.01.13 (fine, no crash) and 2003.01.21 (crashes).
Assignee | ||
Comment 3•22 years ago
|
||
Assignee | ||
Updated•22 years ago
|
Attachment #112787 -
Flags: superreview?(Henry.Jia)
Attachment #112787 -
Flags: review?(kyle.yuan)
Assignee | ||
Updated•22 years ago
|
Attachment #112787 -
Flags: review?(kyle.yuan) → review?(caillon)
Attachment #112787 -
Flags: review?(caillon) → review+
Assignee | ||
Updated•22 years ago
|
Attachment #112787 -
Flags: superreview?(Henry.Jia) → superreview?(jst)
Comment 4•22 years ago
|
||
Comment on attachment 112787 [details] [diff] [review] Prevent selection listener side effects, which were setting mFocusedDocSelection to null sr=jst
Attachment #112787 -
Flags: superreview?(jst) → superreview+
Assignee | ||
Updated•22 years ago
|
Attachment #112787 -
Flags: approval1.3b?
Attachment #112787 -
Flags: approval1.3b? → approval1.3b+
Comment on attachment 112787 [details] [diff] [review] Prevent selection listener side effects, which were setting mFocusedDocSelection to null (Although I do wonder why one is inside the |if| and the other is not.)
Assignee | ||
Comment 6•22 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 7•22 years ago
|
||
*** Bug 190661 has been marked as a duplicate of this bug. ***
Comment 8•21 years ago
|
||
vrfy'd fixed with 2003.02.10 comm trunk bits on win2k, mac 10.2.3 and linux rh8.0.
Status: RESOLVED → VERIFIED
Updated•16 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•