1907590 - Evaluate what we do with extensions interfering with HTTPS Upgrade Telemetry

Status: RESOLVED FIXED

(Core :: DOM: Security, task)

Description

[Christoph Kerschbaumer [:ckerschb}]

We have a mismatch with our HTTPS Upgrade Telemetry (which we added within Bug 1883954) when web extensions upgrade the request. In particular running test_ext_webrequest_upgrade.html highlights the problem. The load starts as http but gets upgraded by the webextension and not through any of our upgrading mechanisms.

Comment 1

[Christoph Kerschbaumer [:ckerschb}]

We have several options:
a) We do nothing and ignore this sideffect
b) We could extend our enum by WEB_EXTENSION_UPGRADE and set it on the loadinfo within HttpBaseChannel::UpgradeToSecure()
c) When recording the telemetry we exempt loads that were modified by web-extensions.

I am personally for (c), though I don't know how to figure that out. The triggeringPrincipal is still the original page that triggered the load. If there is any other bit that we could observe that an extension interfered/modified the load, then I think it would be great to query that and ignore such loads for our telemetry.

Kershaw, Freddy, what are your thoughts?

Comment 2

[Frederik Braun [:freddy]]

I'm leaning towards b) for two reasons:

• We know what to do and where.
• We can filter or single these situations out selectively.

Comment 3

[Kershaw Chang [:kershaw]]

I also prefer option b.
Note that UpgradeToSecure() is currently used only by web extensions, but it may be used by others in the future. While using WEB_EXTENSION_UPGRADE in HttpBaseChannel::UpgradeToSecure is acceptable for now, it’s important to consider making it future-proof.

Comment 4

[Christoph Kerschbaumer [:ckerschb}]

Attachment: Bug 1907590: Improve labels for https telemetry, r=freddyb,kershaw

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e1b34b69a54
Improve labels for https telemetry, r=freddyb,kershaw,necko-reviewers,maltejur

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4e1b34b69a54