1907704 - Update android nightly application-services version bump to new version 8fd08c6f2f8acd38579bd3142fecda9272957b72 from 2024-07-13 05:03:24

Status: RESOLVED FIXED

(Firefox for Android :: General, enhancement)

Description

[Update Bot]

This update covers 9 commits, including 2 new upstream commits I've never filed a bug on before. (They're the top 2.). Here are the overall diff statistics, and then the commit information.

---

mobile/android/android-components/plugins/dependencies/src/main/java/ApplicationServices.kt | 2 +-
mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

8fd08c6f2f8acd38579bd3142fecda9272957b72 by Sammy Khamis <[e-mail]>

https://github.com/mozilla/application-services/commit/8fd08c6f2f8acd38579bd3142fecda9272957b72
Authored: 2024-06-27 11:19:24 -1000
Committed: 2024-07-12 22:07:59 +0000

Remove Tabs.swift as no longer needed

Files Deleted:

• components/tabs/ios/Tabs/Tabs.swift

---

8ec2fa34e5285d78ffa89b98f8e16d825da2d563 by Ben Dean-Kawamura <[e-mail]>

https://github.com/mozilla/application-services/commit/8ec2fa34e5285d78ffa89b98f8e16d825da2d563
Authored: 2024-07-11 16:54:22 -0400
Committed: 2024-07-12 19:21:05 +0000

Bug 1907577 - Fakespot icon support

Fetch the icons using a separate query than manually joined them with
the suggestion data. This has the advantage of not needing to update
the schema.

Also updated the suggest CLI a bit so that I could use it to test that
the code was working in practice.

Files Modified:

• CHANGELOG.md
• components/suggest/src/db.rs
• components/suggest/src/schema.rs
• components/suggest/src/store.rs
• components/suggest/src/suggest.udl
• components/suggest/src/suggestion.rs
• components/suggest/src/testing/data.rs
• examples/suggest-cli/src/main.rs

---

2383edfdd9149d03465d05fa39d85530ec168d1c by Ben Dean-Kawamura <[e-mail]>

https://github.com/mozilla/application-services/commit/2383edfdd9149d03465d05fa39d85530ec168d1c
Authored: 2024-07-11 13:05:17 -0400
Committed: 2024-07-11 20:20:28 +0000

Remove fakespot feature flag

The plan is to use the current code for the experiment, so we don't need
a feature flag anymore. The main point of the flag was to avoid
creating multiple migrations as the schema changed, but it looks like
the schema will be stable for a while.

Files Deleted:

• components/suggest/src/suggest-fakespot.udl

Files Modified:

• components/suggest/Cargo.toml
• components/suggest/build.rs
• components/suggest/src/db.rs
• components/suggest/src/lib.rs
• components/suggest/src/provider.rs
• components/suggest/src/query.rs
• components/suggest/src/rs.rs
• components/suggest/src/schema.rs
• components/suggest/src/store.rs
• components/suggest/src/suggest.udl
• components/suggest/src/suggestion.rs
• components/suggest/src/testing/data.rs
• components/suggest/src/testing/mod.rs
• examples/suggest-cli/Cargo.toml

---

04956ad25b8e4d475215fb20a636555fe4eb3a12 by Lina Butler <[e-mail]>

https://github.com/mozilla/application-services/commit/04956ad25b8e4d475215fb20a636555fe4eb3a12
Authored: 2024-07-10 10:49:57 -0700
Committed: 2024-07-11 00:03:23 +0000

build: Bump our target Rust version to 1.79.0; MSRV to 1.76.0.

This matches the latest versions used in m-c:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1886058 for the
  target version.
• https://bugzilla.mozilla.org/show_bug.cgi?id=1890935 for the MSRV.

Files Modified:

• .circleci/config.yml
• rust-toolchain.toml

---

516f0dd45b98979b2661d2321605e3f35adb07a9 by Lina Butler <[e-mail]>

https://github.com/mozilla/application-services/commit/516f0dd45b98979b2661d2321605e3f35adb07a9
Authored: 2024-07-10 14:51:19 -0700
Committed: 2024-07-11 00:03:23 +0000

build: Bump ctest2 and its dependencies.

The latest version fixes a build-time panic when
building the NSS systest crate with Rust 1.79.0.

Files Modified:

• Cargo.lock

---

d4272d923035c0c751d0ad5b9b8cd5522cf8124d by Lina Butler <[e-mail]>

https://github.com/mozilla/application-services/commit/d4272d923035c0c751d0ad5b9b8cd5522cf8124d
Authored: 2024-07-10 12:47:34 -0700
Committed: 2024-07-11 00:03:23 +0000

all: Fix remaining lint suggestions from Clippy 0.1.79.

Files Modified:

• components/fxa-client/src/internal/mod.rs
• components/fxa-client/src/internal/profile.rs
• components/fxa-client/src/internal/state_manager.rs
• components/nimbus/src/tests/stateful/test_behavior.rs
• components/nimbus/src/tests/test_enrollment.rs
• components/places/src/types.rs
• components/support/error/tests/returns_not_result.rs
• components/support/error/tests/returns_result_but_incorrect_error.rs
• components/support/error/tests/returns_result_but_not_error.rs
• components/support/guid/src/rusqlite_support.rs
• components/support/guid/src/serde_support.rs
• components/support/jwcrypto/src/lib.rs
• components/support/nimbus-cli/src/value_utils.rs
• components/support/nimbus-fml/src/frontend.rs
• components/support/rc_crypto/src/digest.rs
• components/support/rc_crypto/src/hkdf.rs
• components/support/rc_crypto/src/hmac.rs
• components/support/rc_crypto/src/pbkdf2.rs
• components/support/rc_crypto/src/rand.rs
• components/sync15/src/client/request.rs
• components/sync15/src/client/storage_client.rs
• components/sync15/src/telemetry.rs
• components/tabs/src/storage.rs
• components/tabs/src/store.rs
• components/viaduct/src/backend/ffi.rs

---

a4c2b67deb345900b2cb6c62ad37ebb8812d34c2 by Lina Butler <[e-mail]>

https://github.com/mozilla/application-services/commit/a4c2b67deb345900b2cb6c62ad37ebb8812d34c2
Authored: 2024-07-10 12:45:41 -0700
Committed: 2024-07-11 00:03:23 +0000

sync15: Fix range check in ServerTimestamp::from_float_seconds.

f64::{min, max}_value() is deprecated in newer versions of Rust,
and the previous range check allowed millisecond values that can't be
represented in an f64 without loss of precision.

Files Modified:

• components/sync15/src/server_timestamp.rs

---

5d0ad1943102e41b1d30ddd8afbc7af769afb2ad by Lina Butler <[e-mail]>

https://github.com/mozilla/application-services/commit/5d0ad1943102e41b1d30ddd8afbc7af769afb2ad
Authored: 2024-07-10 12:30:24 -0700
Committed: 2024-07-11 00:03:23 +0000

all: Add #[allow(dead_code)] exemptions to prepare for Rust 1.79.0.

Files Modified:

• components/fxa-client/src/internal/http_client.rs
• components/fxa-client/src/internal/util.rs
• components/nimbus/src/stateful/client/mod.rs
• components/push/src/internal/communications.rs
• components/push/src/internal/storage/db.rs
• components/relevancy/src/rs.rs
• components/support/nimbus-cli/src/updater/taskcluster.rs
• components/support/nimbus-fml/src/backends/mod.rs
• components/support/sql/src/conn_ext.rs
• components/sync15/src/telemetry.rs
• testing/sync-test/src/sync15.rs

---

16fdc3b6fee4c5404e77f7034822f5b5d9c464e2 by Ben Dean-Kawamura <[e-mail]>

https://github.com/mozilla/application-services/commit/16fdc3b6fee4c5404e77f7034822f5b5d9c464e2
Authored: 2024-07-02 13:54:14 -0400
Committed: 2024-07-10 15:44:11 +0000

Bug 1905748 - Fakespot ingestion and matching

Create a FTS table for fakespot and populate it during ingestion.
Updated the SuggestQuery code to generate a string to use with the FTS
MATCH operator. I couldn't get DELETE triggers working for this, so I
made it so we delete the FTS data in drop_suggestions.

Also:

• Make the clear_database function delete the FTS data
• Added some more tests for the fakespot data
• Updated the assert_schema_matches_new_database() function to also
  check the triggers. Followed the rule of 3 and refactored things now
  we're checking tables, indexes, and triggers.

Files Modified:

• components/suggest/src/db.rs
• components/suggest/src/query.rs
• components/suggest/src/schema.rs
• components/suggest/src/store.rs
• components/support/sql/src/open_database.rs

---

Comment 2

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=f23e7d6be2ac08fdc27aaedcb06563ff7eee8635

Comment 3

[Update Bot]

Attachment: Bug 1907704 - Update android nightly application-services version bump to 8fd08c6f2f8acd38579bd3142fecda9272957b72

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d97f4d08fef
Update android nightly application-services version bump to 8fd08c6f2f8acd38579bd3142fecda9272957b72 r=dmeehan

Comment 5

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

• generate-profile-android-x86_64-shippable/opt - 1 of 1 failed (failed: BrU8Qsj7RdyNgWq-ykForQ)
• generate-profile-android-x86-shippable/opt - 1 of 1 failed (failed: B6n81_GvTcKD-kzkaPQhJA)

Needs Investigation (Possible Intermittents):

• test-components-android-feature-downloads - 2 of 4 failed on the same (retriggered) task (failed: UFxz33oWTmOyIc2ETLBQ9g, YXUctE2KTlSB9zwLQU3xRQ)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9d97f4d08fef