1907812 - Revert unwanted color changes

Status: RESOLVED FIXED

(Firefox for Android :: Design System and Theming, defect, P2)

Description

[Rebeca Tudor]

Attachment: Before_And_After_regression.png

The patch for Bug 1876719 caused some unwanted color changes.
The first column shows the colors created by the regression (lighter shade) and on the right column it's what's expected.

Comment 1

[Rebeca Tudor]

Attachment: Bug 1907812 - Fix colors regression

The issue was that when in the previous patch, the
accent_high_contrast_normal_theme color was changed,
other than the intended ones were changed as well.
In the previous patch, only the dialog's buttons color was
desired to be changed to resolve an accessibility issue.

In this patch we change back accent_high_contrast_normal_theme
to photonViolet40.
And to resolve the previous ticket that caused
the regression, the button text color of the dialog of the dark mode
was changed from accentHighContrast to accentUsedOnDarkBackground.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1876719

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f85a1b0b98ac
Fix colors regression r=android-reviewers,twhite

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f85a1b0b98ac

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:rebecatudor273, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Mira Lobontiu (Android QA)]

Attachment: 1904977 after.png

Verified as fixed on the latest Fenix Nightly 130.0a1 build from 7/17.
Tested with Samsung Galaxy S24 (Android 14), and Lenovo TB-X606X (Android 10).