1907857 - Some accounts are disabled in Bugzilla but still enabled in Phabricator

Status: RESOLVED FIXED

(Conduit :: Phabricator, defect)

Description

[Mayank Bansal]

I know of two instances :
Network - > mayhemer
Mfbt - > jwalden

This is a low priority bug.

Comment 1

[:glob ✱]

Can you provide an example revision where you saw this behaviour?

Comment 2

[Mayank Bansal]

https://phabricator.services.mozilla.com/D215779

I don't have an example for networking handy

Comment 3

[:glob ✱]

Thanks.

mayhemer's Phabricator and BMO accounts are both active (ie. not disabled), so there's nothing amiss there.

https://phabricator.services.mozilla.com/p/jwalden/ isn't disabled, which is likely why the herald rules they set up are being processed. However, their BMO account is disabled so there's something that needs to be crosschecked. They won't be able to log into Phabricator, but the two systems should be consistent.

dkl: do we have a way to cross-check BMO and Phabricator accounts?

Comment 4

[David Lawrence [:dkl]]

(In reply to :glob ✱ from comment #3)

https://phabricator.services.mozilla.com/p/jwalden/ isn't disabled, which is likely why the herald rules they set up are being processed. However, their BMO account is disabled so there's something that needs to be crosschecked. They won't be able to log into Phabricator, but the two systems should be consistent.

dkl: do we have a way to cross-check BMO and Phabricator accounts?

It should have been disabled automatically at the time the BMO account was disabled but somehow the phab part was not executed. I will look into what happened in this case. Also using the API for both systems I should be able to come up with a script that checks all linked accounts to make sure they are disabled when needed in case others did not work in a similar way.

dkl

Comment 5

[:glob ✱]

Thanks, I'm going to morph this bug to capture core issue.

Comment 6

[David Lawrence [:dkl]]

The majority of the accounts that are disabled in BMO but not in Phabricator are accounts where people disabled themselves in User Preferences. So I will update the code to check for a Phab account and disabled it if the account is being disabled similar to when we do it manually.

Comment 7

[David Lawrence [:dkl]]

The following account have been disabled in Phabricator getting us in sync now:

jhford (John Ford CET/CEST Berlin Time) disabled in BMO but not Phabricator
estellevw (Estelle Weyl) disabled in BMO but not Phabricator
adrian (Adrian Gaudebert) disabled in BMO but not Phabricator
pdknsk () disabled in BMO but not Phabricator
awilfox (A. Wilcox) disabled in BMO but not Phabricator
kamidphish (Dan Glastonbury) disabled in BMO but not Phabricator
phlsa (Philipp Sackl (Design Team)) disabled in BMO but not Phabricator
toros (Tiberius Oros) disabled in BMO but not Phabricator
arthuriakab (Arthur Iakab) disabled in BMO but not Phabricator
viniciuscosta (Vincius Costa) disabled in BMO but not Phabricator
AhmedKadry (Ahmed Kadry) disabled in BMO but not Phabricator
Zlax (Lo Jaillet) disabled in BMO but not Phabricator
Griffin (griffin) disabled in BMO but not Phabricator
jvo (jvo) disabled in BMO but not Phabricator
ethompso28 (Emily Thompson) disabled in BMO but not Phabricator
TrangEmily (TrangEmily) disabled in BMO but not Phabricator
rakanowicz (Ron Akanowicz, UX (needinfo me for questions)) disabled in BMO but not Phabricator
Bisola_Omisore (Bisola Omisore) disabled in BMO but not Phabricator
AaronAmanuel-aamanuel (Aaron Amanuel - aamanuel) disabled in BMO but not Phabricator
JeaneCarlos (Jeane Carlos) disabled in BMO but not Phabricator
krubin (Ken Rubin) disabled in BMO but not Phabricator
RyanAlderete (Ryan Alderete) disabled in BMO but not Phabricator
xhimanshu (xhimanshu) disabled in BMO but not Phabricator
MarcoCovarrubias (Marco Covarrubias) disabled in BMO but not Phabricator
rsbrans (Robert Branson) disabled in BMO but not Phabricator
patrickoshaughnessey (Patrick O'Shaughnessey) disabled in BMO but not Phabricator

I will create a PR to make sure that people who disable their own accounts are also disabled in Phabricator which accounts for half of these. The rest were probably before I added the code that does it automatically.

Comment 8

[David Lawrence [:dkl]]

Actually no change needed. The disabling code is working for the places it needs to. After looking deeper, all of the accounts not disabled were done before the automatic change was added. So we should be good.