1907892 - Consider exposing `accumulate_samples` on MemoryDistribution's trait

Status: NEW

(Data Platform and Tools :: Glean: SDK, enhancement, P4)

Description

[Chris H-C :chutten]

Like bug 1829745 was for TimingDistribution, this bug is for MemoryDistribution. We have a lovely bulk-accumulate method for memory_distribution metrics (accumulate_samples), but we don't offer it to RLB users.

This might be on purpose. Maybe we didn't want just anyone to hold a bunch of samples locally before committing them to the metric. But I'm looking at bug 1906853 with :mxinden and that's wanting to accumulate a memory sample per datagram. We may wish to reconsider past assumptions.

(Also, we give it to Kotlin, so come on.)

Comment 1

[Rishabh]

hello i'd like to contribute to this bug, Although this will be my first contribution. i'm sure with a little help i will be able to do it

Comment 2

[Travis Long [:travis_]]

Hi Rishabh, and welcome! We would love to help mentor you through resolving this bug, and it should be a pretty good "first-bug" for an outside contributor.

The first step would be to ensure you have your development environment set up to build Glean, in this case the bug will require building mostly for Rust, so you will need to ensure you have Rust installed. If you don't then it should be easy to accomplish with the following commands:

curl https://sh.rustup.rs -sSf | sh
rustup update

You can then follow the instructions starting at the guide to contributing found here: https://mozilla.github.io/glean/dev/contributing.html to get you started. This will mostly involve building and testing your changes with make build-rust and make test-rust.

This specific bug has a very similar implementation that was already completed found in Bug 1829745 that you should be able to use as a template for the work that is expected here.

Please don't hesitate to ask any questions that come up, we would be happy to guide you as needed!

Comment 3

[Chris H-C :chutten]

(marking unassigned due to inactivity)

Comment 4

[poglesbyg]

Is this still available? I'd like to give it a go.

Comment 5

[BMO Github Automation]

Attachment: [mozilla/glean] Bug 1907892 Consider exposing `accumulate_samples` on MemoryDistribution's trait (#3140)

Comment 6

[Jan-Erik Rediger [:janerik]]

Attachment: [mozilla/glean] Bug 1907892 - Expose memory distribution accumulate samples (#3141)