1907983 - extract_sym_header_data breaks out too early

Status: RESOLVED FIXED

(Tecken :: Upload, defect, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Over time, we've added additional INFO lines in the symbol file header to capture additional contextual data about the symbol file. Example:

MODULE Mac arm64 C6932EE0F2393548B557F31516EB8BCC0 TestPrintf
INFO CODE_ID C6932EE0F2393548B557F31516EB8BCC
INFO RELEASECHANNEL beta
INFO VERSION 130.0
INFO VENDOR Mozilla
INFO PRODUCTNAME Firefox
INFO BUILDID 20240715153258
INFO GENERATOR mozilla/dump_syms 2.3.3

The problem is that extract_sym_header_data breaks out as soon as it finds a line it doesn't recognize and the only ones it recognizes are MODULE, INFO GENERATOR, and INFO CODE_ID. Thus with the above header, it stops parsing at INFO RELEASECHANNEL and never captures the generator information.

This covers fixing extract_sym_header_data to parse the whole header and capture the generator.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: [mozilla-services/tecken] bug-1907985: fix sym file header parsing (#2991)

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR [mozilla-services/tecken]: bug-1907983: fix sym file header parsing (#2991) in 1362e1f.

Comment 3

[Sven Marnach :sven]

This was deployed in bug 1916984 with tag v2024.09.05.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Symbols Server correctly captured the generator on this newly uploaded linux lib symbols file:

https://symbols.mozilla.org/uploads/files/file/64988602

Symbols Server correctly captured all the information on this newly uploaded windows dll symbols file:

https://symbols.mozilla.org/uploads/files/file/64988260

Looks like this is fixed now.