Open Bug 1908310 Opened 7 months ago Updated 6 months ago

Look up gesture is not working on shadow root text nodes

Categories

(Core :: Panning and Zooming, defect, P3)

defect

Tracking

()

UNCONFIRMED

People

(Reporter: metasieben, Unassigned)

References

()

Details

The look up gesture(three finger tap) seems to be not working on shadow root text nodes.
Working as expected in Safari/Chrome.

STR

  1. Open https://mdn.github.io/web-components-examples/word-count-web-component/
  2. Try to look up(three finger tap) the text "Words" at the end

Previous work on this feature has been done in the panning and zooming component, so engineers familiar with that code might be found there.

You are right, thanks.
Moving to the correct component.

Component: Widget: Cocoa → Panning and Zooming

Given that it doesn't work text in shadow root ones, the cause is probably similar to bug 1894162, we probably just try to obtain the parent, not the shadow host. It's unlikely an APZ issue, though I don't know there the lookup feature code is.

(In reply to Hiroyuki Ikezoe (:hiro) from comment #3)

I don't know there the lookup feature code is

I think it may be here (and in particular the OnQueryTextRect function which was also modified in this patch).

I think we were the last to touch this code when we made it work with pinch zoom on desktop.

The severity field is not set for this bug.
:botond, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(botond)
Severity: -- → S3
Priority: -- → P3
Flags: needinfo?(botond)

When trying to reproduce (which I could) we found that selecting the text in the shadow node also does not work. On the chance these bugs are related, I'm adding Bug 1562561 to 'see also'.

See Also: → 1562561
You need to log in before you can comment on or make changes to this bug.