1908320 - [css-grid] Orthogonal items should also participate in baseline alignment

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect, P3)

Description

[Tiaan Louw [:tlouw]]

All items in an alignment context should be checked for baseline alignment. Items that turn out to be orthogonal to the alignment context should synthesize a baseline.

Comment 1

[Tiaan Louw [:tlouw]]

Attachment: Bug 1908320 - Orthogonal items should also participate in baseline alignment r=#layout-grid-reviewers

All items in an alignment context should be checked for baseline
alignment. Items that turn out to be orthogonal to the alignment
context should synthesize a baseline.

Comment 2

[Tiaan Louw [:tlouw]]

Attachment: Bug 1908320 - No baseline alignment if there are no parallel items. r=#layout

If an alignment group has no items with a baseline parallel to the
baseline alignment axis, then the fallback alignment is used.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99afd830a8bd
Orthogonal items should also participate in baseline alignment r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/86c1052ebb70
No baseline alignment if there are no parallel items. r=layout-reviewers,emilio

Comment 4

[Iulian Moraru]

Backed out for causing wr failures on align-items-baseline-column-vert.html.

• Push with failures

• Failure log

• Backout link
  ''' INFO '''

The reftestanalyzer says that the images are identical.

''' INFO '''

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99b3bcd44315
Orthogonal items should also participate in baseline alignment r=layout-reviewers,emilio

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/99b3bcd44315