1908350 - Update android nightly application-services version bump to new version 8995a0d108e65295b595fa7891b39aea88268906 from 2024-07-17 06:05:03

Status: RESOLVED FIXED

(Firefox for Android :: Accounts and Sync, enhancement)

Description

[Update Bot]

This update covers 2 commits. Here are the overall diff statistics, and then the commit information.

---

mobile/android/android-components/plugins/dependencies/src/main/java/ApplicationServices.kt | 2 +-
mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

8995a0d108e65295b595fa7891b39aea88268906 by Lina Butler <[e-mail]>

https://github.com/mozilla/application-services/commit/8995a0d108e65295b595fa7891b39aea88268906
Authored: 2024-07-15 15:46:52 -0700
Committed: 2024-07-16 23:02:00 -0700

fxa-client: Replace DeviceCommandError with CloseTabsResult.

This commit demotes the TabsNotClosed error case from a
DeviceCommandError variant, to a CloseTabsResult variant
specifically for "close tabs".

FirefoxAccount::close_tabs only throws FxaErrors for
account-related errors, as before. Successes and partial successes
are reported via CloseTabsResult.

Files Modified:

• components/fxa-client/android/src/main/java/mozilla/appservices/fxaclient/FxaClient.kt
• components/fxa-client/ios/FxAClient/FxAccountDeviceConstellation.swift
• components/fxa-client/ios/FxAClient/PersistedFirefoxAccount.swift
• components/fxa-client/src/device.rs
• components/fxa-client/src/error.rs
• components/fxa-client/src/fxa_client.udl
• components/fxa-client/src/internal/close_tabs.rs
• components/fxa-client/src/lib.rs
• components/fxa-client/src/push.rs

---

09a30f37dc18e5c1dc957f75f501e7eddb085d17 by Lina Butler <[e-mail]>

https://github.com/mozilla/application-services/commit/09a30f37dc18e5c1dc957f75f501e7eddb085d17
Authored: 2024-07-09 21:36:47 -0700
Committed: 2024-07-16 23:02:00 -0700

fxa-client: Chunk oversized "close tabs" commands.

This commit:

• Introduces a new DeviceCommandError type for
  device command-related operations.
• Adds a DeviceCommandError::TabsNotClosed error variant, which
  includes the URLs of any tabs that couldn't be sent in a
  "close tabs" command.
• Reworks FirefoxAccount::close_tabs to pack URLs that exceed the
  maximum payload size (16 KB by default) into multiple
  device commands.

Files Modified:

• Cargo.lock
• components/fxa-client/Cargo.toml
• components/fxa-client/src/error.rs
• components/fxa-client/src/fxa_client.udl
• components/fxa-client/src/internal/close_tabs.rs
• components/fxa-client/src/internal/commands/close_tabs.rs
• components/fxa-client/src/internal/device.rs
• components/fxa-client/src/internal/telemetry.rs
• components/fxa-client/src/lib.rs
• components/fxa-client/src/push.rs

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=b8540cf83c11f38bd5eddf1576e51c0df6118649

Comment 2

[Update Bot]

Attachment: Bug 1908350 - Update android nightly application-services version bump to 8995a0d108e65295b595fa7891b39aea88268906

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Accounts and Sync' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51236e3a6ce0
Update android nightly application-services version bump to 8995a0d108e65295b595fa7891b39aea88268906 r=lina

Comment 5

[Update Bot]

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/51236e3a6ce0