190840 - Conn: connection establishment timeout - no error

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P3)

Description

[Warner Young]

If you try to visit a site but the connection times out, there is no error
message or any other indication that something is wrong.  I'm pretty sure this
used to produce an error.

Started recently (last few days, I think).  I'm seeing it with build 2003012709,
Win98.  The site I was trying to visit was www.tech-report.com, but your mileage
may vary, so I can't give a 100% reproducible test case.

Also, please DUPEME.  I'm almost positive this has to be a dupe, but I can't
find the bug to dupe against.

Comment 1

[Matthias Versen [:Matti]]

-> Http

Comment 2

[benc]

darin: I think we talked abou this in the pre-checkin AIO builds you gave me, is
this expected?

Comment 3

[Darin Fisher]

ben: yeah, i recall that.  i wasn't able to repro the "no timeout" error
message, and the code for the timeout error mapping remains intact.  i'll have
to dig a little more to see what's really going on.  i don't think this is a
major regression.

Comment 4

[Darin Fisher]

ok, i think this problem might occur when a connection is established, but an
attempt to write times out.  we only check for PR_CONNECT_TIMEOUT_ERROR, but not
PR_IO_TIMEOUT_ERROR.  i'm running some tests on slashdotted sites now ;-)

Comment 5

[Darin Fisher]

Attachment: v1 patch

yup, that's it!  easy patch.

Comment 6

[Darin Fisher]

will try for 1.3 beta.

Comment 7

[Doug Turner (:dougt)]

Comment on attachment 112821 [details] [diff] [review]
v1 patch

sure.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 112821 [details] [diff] [review]
v1 patch

Let's pretend I haven't reviewed this code yet, ok?  ;)

Comment 9

[Darin Fisher]

Comment on attachment 112821 [details] [diff] [review]
v1 patch

simple patch to improve error messages while browsing slashdotted websites ;-)

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 112821 [details] [diff] [review]
v1 patch

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 11

[Darin Fisher]

fixed-on-trunk

Comment 12

[benc]

The error still did not work in 1.3b, because of bug 192825.

I'll go back and check a Win build between your checkin and 1.3b to verify this.

If someone pulled a daily build and saw this fixed, please mark this verified.

NOTE: you must not be using a proxy.