1908426 - UI shown after creating a group

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task)

Description

[Dão Gottwald [:dao]]

Figma: https://www.figma.com/design/f6J2lH6XDxLxyzOLr2E8oE/Tab-Grouping?node-id=8113-148797&t=yIMA80oXn1yJy1MA-0

Comment 1

[DJ]

Attachment: Bug 1908426 - add UI to edit group label / color after creation. r?jswinarton,dao!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fad1cda93cc8
add UI to edit group label / color after creation. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing multiple failures

Backout link

Push with failures

Failure log // Failure log 2

Comment 4

[DJ]

Andrew, Gijs suggested I ping you about the asan failure linked above. From what I can tell, the error has something to do with the radio inputs generated in tabgroup-menu.js. Any ideas on how I can solve this?

Comment 5

[Andrew McCreight [:mccr8]]

It looks like you are hitting a bug in the memory reporter for the DOM radio buttons implementation. I'll see if I can reproduce locally. I'll file a bug blocking this one.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e5b4312b174
add UI to edit group label / color after creation. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson

Comment 7

[Atila Butkovits]

Backed out for causing failures at browser_tab_groups.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/129c9199f04ce64b75a2eae51e7184361b00296f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=os%2Cx%2C10.15%2Cwebrender%2Cshippable%2Copt%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Ctest-macosx1015-64-shippable-qr%2Fopt-mochitest-browser-chrome-spi-nw%2Cbc2&revision=2e5b4312b174841103aeaa34849d85e61129e832&selectedTaskRun=ZTrl7E8sT86wyrjzv3tpjg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=476382064&repo=autoland&lineNumber=6161

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d80c2b998895
add UI to edit group label / color after creation. r=jswinarton,dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d80c2b998895