1908521 - Suspected dead code in parser

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

While reviewing a patch I realized that I couldn't figure out how we could ever error in these lines

We definitely have no test coverage of this.

Can we remove these checks, or perhaps convert this to an assert?

Comment 1

[Joshua Chen]

I think it's this case? class X { x: 1 }

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Ah! Perfect. Thanks. I'll add a test case for this -- it's weird we don't have any coverage of this!

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

(Why don't I just use this bug to land test case..)

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1908521 - Add coverage for previously missed syntax error r?arai

Analyzing if there's any other cases which would be interesting:

1. CoverInitializedName isn't supposed to be generated inside a class, so can't test for that.
2. Shorthand also cannot be created inside a class.
3. Field and FieldWithAccessor is handled in the block prior to this one.

That leaves Constructor and DerivedConstructor, which I think are handled elsewhere.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76792eb1472f
Add coverage for previously missed syntax error r=arai

Comment 6

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/76792eb1472f