190862 - default GRE installation path should be Common Files

Status: VERIFIED FIXED

(Core Graveyard :: Installer: GRE, defect)

Description

[Sean Su]

Comment 1

[Charles Rosendahl]

Sean, 

how is this diferent from bug 190714?

Comment 2

[Sean Su]

Attachment: patch v1.0

moving patch from bug 190714 to here.

Comment 3

[Sean Su]

Comment on attachment 112797 [details] [diff] [review]
patch v1.0

got r=sgehani when patch was attached to bug 190714.  just needs sr= now.

Comment 4

[Sean Su]

Charles, bug 190714 was requesting that it allow users to change where GRE gets
installed to.  I wanted to keep that bug as it was, and file a new one for
changing the default GRE path.

This bug should be topembed/blocker 1.3b, not the other one.

Comment 5

[Michael Buckland]

dveditz, can you sr= this?  Plussing.

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 112797 [details] [diff] [review]
patch v1.0

rs=sspitzer

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 112797 [details] [diff] [review]
patch v1.0

sr=dveditz

Comment 8

[Asa Dotzler [:asa]]

carosendahl, only drivers can set the "+" on blocking flags.

Comment 9

[Sean Su]

patch checked in.  marking bug fixed.

Comment 10

[Patrick]

I just uninstalled Moz 20030127 on XP Pro SP1 and manually cleared out remaining
Mozilla folders. Then i installed 2003013008 from the sea.

This still created a \program files\mozilla.org folder for the GRE and no GRE
can be found in \common files\

Comment 11

[Sean Su]

yeah... that's a different problem caused by several factors.  the GRE
installer, right now, always tries to look for where the previous GRE was
installed to (regardless if it's still on the system or not).  This is done by
looking at:
  HKEY_CURRENT_USER\Software\mozilla.org\GRE\1.3b

if you unisntall everything again, delete GRE and mozilla, make sure
HKEY_CURRENT_USER\Software\mozilla.org\GRE does not exists, GRE should then get
installed into the common files folder.

Comment 12

[Patrick]

Using Moz 2003013008 on Win2K Pro SP3, i uninstalled and then manually deleted
GRE and mozilla folder. After that i deleted
HKEY_CURRENT_USER\Software\mozilla.org\GRE

Then reinstalled Moz to \program files\mozilla\
Still GRE installs in \program files\mozilla.org

So at least one of us must've made a mistake! ;)

Comment 13

[stefan.buerbaum]

@Patrick Hendriks

After uninstall delete ALL registry entries, there are more than this one.
But on my system, I tried to change the GRE Path, it don't work.
And the Mozilla key's in the Registry were corrupt.
(Yes, I have deletet all enties)
Only installing a older Build (from 21st) and reinstalling the Build from 30th
could recover my Installation.
OS: W98 (1st edition)

Please let the user set the Installaton path for the GRE, the common files dir
is NOT the ideal DIR on all systems.
I have only the W98 in the C:\ Disk, all apps and the data are on other disks.

Stefan

Comment 14

[Patrick]

Per comment 11 and comment 13. There is indeed an additional registry key in
HKEY_LOCAL_MACHINE\Software\mozilla.org\GRE that needs to be deleted to reset
the default installation folder for the GRE.

Comment 13: letting the user set the path for the GRE is dealt with by bug 190714.