1908626 - change default index rank for tier-{2,3} tasks from zero to one

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Julien Cristau [:jcristau]]

Historically we've set index rank based on the build date for tier-1 tasks, and to 0 for tier-{2,3} tasks, which AIUI was useful during the migration from buildbot to taskcluster because we could have the same builds running in both with different tiers, and have only the tier-1 task get indexed.

Later (bug 1653050) we added eager-index for cached tasks, to avoid rebuilding docker images / toolchains / etc that were already in progress on a previous push: we'd now find the previous push's tasks in the index and wait for them to finish.

This was fine for tier-1 cached tasks, but for tier-{2,3}, when they get scheduled without their cache hash (and thus index path) actually changing, we'd now override a previous successful (rank 0) index entry with an unscheduled or pending or running task, leading to a window where artifacts aren't available (bug 1720793 / bug 1908324).

It seems this problem would go away if we used 1 instead of 0 as the default index for tier-{2,3} tasks.

Comment 1

[Julien Cristau [:jcristau]]

Attachment: Bug 1908626 - use one as default index rank for tier-2 and tier-3 tasks.

This ensures completed tasks have a higher rank than entries added by
eager-index, when a cached task is scheduled despite not changing index
path.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9a9cc04a8b0
use one as default index rank for tier-2 and tier-3 tasks. r=taskgraph-reviewers,bhearsum DONTBUILD

Comment 3

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/d9a9cc04a8b0