1908748 - [wpt-sync] Sync PR 47194 - Remove Chromium specific code from deviceId wpt tests

Status: RESOLVED FIXED

(Core :: DOM: Events, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47194 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47194
Details from upstream follow.

Sahir Vellani <[e-mail]> wrote:

Remove Chromium specific code from deviceId wpt tests

These tests early out in other browsers because windows.internals is
not defined. Remove the relevant code because the feature flag check no
longer exists in these tests and they have been moved to wpt.

Bug: 1420685
Change-Id: I02adc1912ac05501f9efc4a29055f711454c786f
Reviewed-on: https://chromium-review.googlesource.com/5722238
WPT-Export-Revision: ebda51cc67ce60c7f98f609b07441b54cfab16fd

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=55c46c2a6580c7869b3b6636badf63d674514f79

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 2 subtests

Status Summary

Firefox

OK : 2
FAIL : 3

Chrome

OK : 2
PASS : 3

Safari

OK : 1
PASS : 1
FAIL : 2
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /pointerevents/persistentDeviceId/get-persistendeviceid-from-pointer-event.tentative.html [wpt.fyi]
  • PointerEvent.persistentDeviceId: FAIL

New Tests That Don't Pass

• /pointerevents/persistentDeviceId/get-persistendeviceid-from-pointer-event.tentative.html [wpt.fyi]
  • PointerEvent.persistentDeviceId: FAIL (Chrome: PASS, Safari: PASS)
• /pointerevents/persistentDeviceId/pointer-event-has-persistentdeviceid-from-pointer-event-init.tentative.html [wpt.fyi]
  • PointerEvent.persistentDeviceId via PointerEventInit: FAIL (Chrome: PASS, Safari: FAIL)
  • No persistentDeviceId in PointerEventInit: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a753dc93dbe
[wpt PR 47194] - Remove Chromium specific code from deviceId wpt tests, a=testonly
https://hg.mozilla.org/integration/autoland/rev/be58d54e04a5
[wpt PR 47194] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing wpt failures in idlharness.https.html.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0f7724f4ead
[wpt PR 47194] - Remove Chromium specific code from deviceId wpt tests, a=testonly
https://hg.mozilla.org/integration/autoland/rev/90f8dcbdfd79
[wpt PR 47194] - Update wpt metadata, a=testonly

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e0f7724f4ead
https://hg.mozilla.org/mozilla-central/rev/90f8dcbdfd79