190879 - FindChar() should assert and return kNotFound if called with offset > string length

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect)

Description

[(not reading, please use [e-mail] instead)]

FindChar() should assert and return kNotFound if called with offset > string 
length

see http://bugzilla.mozilla.org/show_bug.cgi?id=187065 for an example of this.

of course, callers shouldn't be doing this.

but can we add some code to assert and bail on this?

Comment 1

[jag (Peter Annema)]

Should that code be debug only? I'd rather we fix all callers than burden
everyone with this check.

Comment 2

[Atul Aggarwal]

I checked and found that all the string (nsTSubstring.cpp, nsStringAPI.cpp) are checking for offset < length and are returning -1 (kNotFound) if found.

http://mxr.mozilla.org/mozilla-central/source/xpcom/string/src/nsTSubstring.cpp#675
http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsStringAPI.cpp#875

I guess this bug has been fixed and hence marking it as Resolved/WorksForMe.

Comment 3

[Atul Aggarwal]

Feel free to open in case you found the problem in the existing code (which I missed).