1908961 - In custom tab, prompts/menus/findbar are shown with a theme that conflicts with the rest of the UI, if Firefox theme is different from OS theme

Status: NEW

(Firefox for Android :: Tabs, defect, P2)

Description

[Daniel Holbert [:dholbert]]

Steps to reproduce

(similar to bug 1908954)

1. Set Firefox to have a different light/dark setting from Android (e.g. set Android to "dark" in settings, and Firefox Nightly to "light" in Firefox settings "customize" section)
2. Tap a link in your email (with Firefox set as your default browser).
3. Tap something on the Firefox toolbar that spawns a prompt or a menu -- e.g. tap the lock icon, or the share button, or the 3-dot-menu, or the 3-dot-menu-and-then-Find-in-page (to make the find-in-page UI appear), or tap something that triggers a geolocation prompt (e.g. the "get current position" button on https://www.audero.it/demo/geolocation-api-demo.html shown in an app-tab)

Expected behavior

The prompt/menu/find-in-page UI should have the same theme as the surrounding browser/system UI (like the top/bottom android trays and the main Firefox toolbar) -- it should probably be dark in this case (since we seem to mostly be inheriting the system theme from the app that we're "embedding into" when creating an custom tab).

Actual behavior

The popups are light-themed (disagreeing with the surrounding system/Firefox-toolbar UI)

Device information

• Firefox version: 130.0a1 2024-07-18, Firefox 129.0b5 (those are just what I've tested this in, but I suspect this goes back a while)
• Android device model: Pixel 8
• Android OS version: 14

More information

This is sort of a more general / older version of bug 1908954. Bug 1908954 is specifically about this same problem making the navbar white (which is the most prominent/grating version of this issue, since it's in-view right away and directly-alongside conflicting UI), whereas this bug that I'm filing here is about the fact that this same problem has been affecting other UI for some time, before the navbar work (not sure how long, but I can reproduce in e.g. Firefox 129.0b5, pre-navbar-being-enabled).

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug affecting Firefox menu in custom tab (in Firefox Beta 129)

Comment 2

[Delia Pop (Android QA)]

Attachment: CustomTabs_NavigationArrows_Themes.jpg

Using a different theme in Fenix compared to the system theme, also affects the contrast between the navigation arrow buttons and the nav bar background.
Attaching screenshots from latest Nightly 132.0a1 from 09/26 and Google Pixel 8 Pro (Android 14).