1909211 - Add Bookmark dialog suggests all already entered tags instead those ones related to the one being currently entered

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[hawran]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0

Steps to reproduce:

1. Add a bookmark (ctrl+d).
2. Enter a couple of tags.

Actual results:

The edit field for tags shows (suggests? autocompletes?) all tags already entered with a bookmark being added instead of just (all existing) tags related to a tag being added.
When the edit field is full of tags, the new tag is not shown.

Expected results:

Before this update the edit field suggested (autocompleted) all existitng tags, however just related to the tag being entered.

Comment 1

[hawran]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0
OS: Linux 6.5.0-44-generic #44~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Jun 18 14:36:16 UTC 2

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[mk361]

This happens not only in the "Add bookmark" dialogue, but also in the bookmarks manager (when editing a single bookmark's tags); in "Add bookmark" it's far more annoying since the tag input field and the associated dropdown are so narrow.

I'm seeing this behaviour in the Windows version of Firefox (127.0.2), too.

This is apparently really a regression in Firefox 127.0 - just to be sure, I've re-installed 126.0.1 (firefox/releases/126.0.1/linux-x86_64/en-US/firefox-126.0.1.tar.bz2), and it doesn't show this behaviour.

Comment 4

[mk361]

I'm sorry, but I got really confused about the version numbers - I somehow believed I was on 127.0.2, while I'm actually on 128.0.2.

I re-tested the previous release (firefox/releases/127.0.2/linux-x86_64/en-US/firefox-127.0.2.tar.bz2), and the behaviour didn't occur - so the bug apparently first appears in 128.0.

Sorry about the confusion.

Comment 5

[Marco Bonardo [:mak]]

I ran mozregression and found this is a regression from Bug 1886064.

The TaggingService uses AutoCompleteSimpleResult instance's AppendMatch

  void appendMatch(in AString aValue,
                   in AString aComment,
                   [optional] in AString aImage,
                   [optional] in AString aStyle,
                   [optional] in AString aFinalCompleteValue,
                   [optional] in AString aLabel);

We're passing this._result.appendMatch(before + tag, tag);
It looks like the new behavior requires us to pass tag as aLabel instead of aComment.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1886064

:enndeakin, since you are the author of the regressor, bug 1886064, could you take a look?

For more information, please visit BugBot documentation.

Comment 7

[Marco Bonardo [:mak]]

This is trivial, though I'd like to check our testing story.

Comment 8

[Marco Bonardo [:mak]]

Attachment: Bug 1909211 - Bookmark dialogs suggests all already entered tags instead of just the new matching one. r=daisuke

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/693fe3b405c1
Bookmark dialogs suggests all already entered tags instead of just the new matching one. r=daisuke,places-reviewers

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/693fe3b405c1

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mak, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Marco Bonardo [:mak]]

we're in RC week, not worth uplifting to beta.
We should consider ESR though.

Comment 13

[Marco Bonardo [:mak]]

Attachment: Bug 1909211 - Bookmark dialogs suggests all already entered tags instead of just the new matching one. r=daisuke

Original Revision: https://phabricator.services.mozilla.com/D217803

Comment 14

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Bookmark tags autocomplete malfunctioning
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Typing more than one tag should only show the last tag in the autocomplete panel
• Risk associated with taking this patch: low
• Explanation of risk level: single line fix, adapting to the underlying code changes
• String changes made/needed: none
• Is Android affected?: no

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/bc1b261a7c07

Comment 16

[Ciprian Georgiu, Desktop QA]

I have reproduced this issue using an affected Nightly build 2024-07-22 with STR from comment 0.

The issue is verified as fixed on FirefoxEsr 128.2.0 and RC1 130 under macOS 14, Ubuntu 22 and Win 11.