1909220 - Allow embeddings to define classes without a globally available constructor

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[jake champion]

Steps to reproduce:

Currently it is not possible for an embedding to create builtin classes using JS_InitClass without exposing the class' constructor globally, this is an issue if the embedding wants to create classes which are not found on the global.

I propose we modify JS_InitClass to respect js::ClassSpec::DontDefineConstructor so that it would be possible for an embedding to create such builtin classes

Comment 1

[jake champion]

Attachment: Bug 1909220 - Respect js::ClassSpec::DontDefineConstructor in DefineConstructorAndPrototype. r=jandem

The flag was previously only respected for internal builtins, not classes defined by the embedding using JS_InitClass. That meant one couldn't use JS_InitClass to define classes without a globally available constructor.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7898786b44c9
Respect js::ClassSpec::DontDefineConstructor in DefineConstructorAndPrototype. r=jandem

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7898786b44c9