1909256 - Nimbus rollout for weather location (weatherLocationSearch) should use setPref instead of fallbackPref

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 1909256 - Update FeatureManifest weatherLocationSearch to use setPref instead of fallbackPref r?#home-newtab-reviewers

Comment 2

[Scott [:thecount] Downe]

So essentially this isn't properly hooked up to Nimbus.

It works locally when flipping the pref, which is what we mostly do when we QA.

This did not get properly hooked up in Nimbus.

We did a rollout for this, and are now noticing users are not see the location picker. Tracked it down to this pref/nimbus issue.

The fix is small.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12a0d92965a4
Update FeatureManifest weatherLocationSearch to use setPref instead of fallbackPref r=home-newtab-reviewers,nbarrett

Comment 4

[Maxx Crawford [:maxx]]

Attachment: Bug 1909256 - Update FeatureManifest weatherLocationSearch to use setPref instead of fallbackPref r?#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D217289

Comment 5

[Maxx Crawford [:maxx]]

Attachment: Bug 1909256 - Update FeatureManifest weatherLocationSearch to use setPref instead of fallbackPref r?#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D217289

Comment 6

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Weather feature rollout will not have location picker which could impact user experience
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Regression testing for weather location picker. See test steps in https://bugzilla.mozilla.org/show_bug.cgi?id=1909256
• Risk associated with taking this patch: Low
• Explanation of risk level: One line change in Nimbus variable
• String changes made/needed: No
• Is Android affected?: no

Comment 7

[Scott [:thecount] Downe]

Steps to test:

1. Set "browser.newtabpage.activity-stream.system.showWeather" to true
2. Set "browser.newtabpage.activity-stream.weather.locationSearchEnabled" to true
3. Restart
4. Open newtab
   Expected: should see weather widget in top left, and location picket in "..." menu.

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Weather feature rollout will not have location picker which could impact user experience
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Regression testing for weather location picker. See test steps in https://bugzilla.mozilla.org/show_bug.cgi?id=1909256
• Risk associated with taking this patch: Low
• Explanation of risk level: One line change in Nimbus variable
• String changes made/needed: No
• Is Android affected?: no

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/7853bd07dfa8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9414169 [details]
Bug 1909256 - Update FeatureManifest weatherLocationSearch to use setPref instead of fallbackPref r?#home-newtab-reviewers

Approved for 128.1esr.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/20d1d5ce07ff

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/12a0d92965a4

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/0cf5ec796d19

Comment 15

[Timea Zsoldos [:tzsoldos], Desktop QA]

Reproduced the issue on Firefox nightly 130.0a1 from 2024.07.22, verified across platforms (Windows 10, macOS 10.15 and on Ubuntu 22) with steps form comment 7, on latest nightly 135.0a1, build from 2024.12.04 and on Firefox 134.0b4, now the weather feature have the location picker. Tested across platforms with Fx128, Fx129, Fx130 and Firefox 128esr versions, the weather feature have location picker.