1909311 - Remove nsI{Text,Form}ControlFrame.

Status: RESOLVED FIXED

(Core :: Layout, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1909311 - Remove nsIFormControlFrame and nsITextControlFrame. r=smaug,masayuki,#layout

It's a rather useless interface:

• nsITextControlFrame is only implemented by nsTextControlFrame, so we
  can just use that.
• nsIFormControlFrame had very few actual functionality, mostly
  scattered around:
  • SetFormProperty(select) was only useful for nsTextControlFrame.
  • SetFormProperty(value) was only called on file controls.
  • SetFocus() did mostly nothing, or things that can be done in
    ElementStateChanged instead.

There are some do_QueryFrame calls that I replaced for better checks in
font inflation and nsIFrame, but I'll adjust to preserve behavior if you
insist (it just such a somewhat-random check).

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1909311 - Misc clean ups to nsSearchControlFrame. r=#layout

I realized while looking at the previous patch that enabling the search
button technically changes behavior of the IsTextInputFrame() checks.

Do the same we do for nsNumberControlFrame for consistency, and clean-up
the code while at it.

This doesn't change behavior because this code is not enabled by
default.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe6e34491cdb
Remove nsIFormControlFrame and nsITextControlFrame. r=masayuki,layout-reviewers,dholbert
https://hg.mozilla.org/integration/autoland/rev/10f23d70c967
Misc clean ups to nsSearchControlFrame. r=layout-reviewers,TYLin
https://hg.mozilla.org/integration/autoland/rev/794c0df6ca15
apply code formatting via Lando

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc53364019a1
Fix for test_selection_tripleclick.html.

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fe6e34491cdb
https://hg.mozilla.org/mozilla-central/rev/10f23d70c967
https://hg.mozilla.org/mozilla-central/rev/794c0df6ca15
https://hg.mozilla.org/mozilla-central/rev/cc53364019a1