Closed
Bug 1909333
Opened 2 months ago
Closed 1 month ago
Change `AcornWindowSize.getWindowSize` to use `LocalConfiguration.current.smallestScreenWidthDp` instead of `screenWidthDp`
Categories
(Fenix :: Design System and Theming, task, P1)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: 007, Assigned: 007)
References
(Blocks 1 open bug)
Details
LocalConfiguration.current.screenWidthDp
gets the app window's current width in the current orientation. Instead, we might want to use smallestScreenWidthDp
.
smallestScreenWidthDp
functions similarly to the sw600dp
, smallest width resource property, where the smallest width possible, regardless of orientation is returned.
smallestScreenWidthDp
should be used IFF we want the minimum width used to enforce a screen size minimum AND we don't want to just show a particular layout whenever the width threshold is met.
- In other words, just because a phone may fall into the
Medium
size category when in landscape, we might still want to show theSmall
window layout. (Similar to how sw600dp functions today)
Confirm this behavior change/parity with Crystal and Jules first.
Assignee | ||
Comment 1•1 month ago
|
||
I'm integrating this over in Bug 1909554. We should instead have two use paths:
- Having logic forks for determining when the window size is large enough to branch for UI differences.
- Having logic forks for determining when the physical hardware is large enough for certain UI or feature differences.
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•