1909339 - Add initial support for the 'anchor-center' value

Status: RESOLVED FIXED

(Core :: Layout: Positioned, enhancement, P3)

Description

[Jonathan Watt [:jwatt]]

We should add initial support for the anchor-center value to the properties 'justify-self', 'align-self', 'justify-items' and 'align-items'.

Comment 1

[Keith Cirkel [:keithamus]]

Attachment: Bug 1909339 - Correctly position anchor-center position-area values r?#layout

This plumbs in the Anchor's rect so that AlignJustifySelf centres on the
anchor size + offsets, rather than the CB.

Comment 2

[Keith Cirkel [:keithamus]]

Attachment: Bug 1909339 - Implement anchor-center for alignment properties when anchored r?#layout

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/461b86ef9b9c
https://hg.mozilla.org/integration/autoland/rev/c3256c432d8e
Implement anchor-center for alignment properties when anchored r=layout-reviewers,emilio,firefox-style-system-reviewers,dshin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c139426e28c6
https://hg.mozilla.org/integration/autoland/rev/4944374d040d
Revert "Bug 1909339 - Implement anchor-center for alignment properties when anchored r=layout-reviewers,emilio,firefox-style-system-reviewers,dshin" for causing bustages at ReflowInput.cpp

Comment 5

[Atila Butkovits]

Backed out for causing bustages at ReflowInput.cpp

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/4944374d040d108bde553f5ba229fbb3b2dcac6f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=VCXyiISoS9mN2OvfcIwODw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c3256c432d8e8b23d2d84d1a34e7e217ac6ef2c9

Failure log: https://treeherder.mozilla.org/logviewer?job_id=538411029&repo=autoland&task=VCXyiISoS9mN2OvfcIwODw.0&lineNumber=116007

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/56474 for changes under testing/web-platform/tests

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1c5f80bd63ed
https://hg.mozilla.org/integration/autoland/rev/77af4bb68560
Implement anchor-center for alignment properties when anchored r=layout-reviewers,emilio,firefox-style-system-reviewers,dshin

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/77af4bb68560

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot