Closed Bug 190939 Opened 22 years ago Closed 22 years ago

JS error and strict warning in sidebarOverlay.js

Categories

(SeaMonkey :: Sidebar, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: neil, Assigned: shliang)

Details

(Keywords: regression)

Attachments

(1 file)

Error: pt has no properties Source File: chrome://communicator/content/sidebar/sidebarOverlay.js Line: 1504 Warning: redeclaration of var ds Source File: chrome://communicator/content/sidebar/sidebarOverlay.js Line: 805, Column: 7 Source Code: var ds = RDF.GetDataSource(sidebarObj.datasource_uri)
Attached patch Proposed patchSplinter Review
Attachment #112857 - Flags: superreview?(alecf)
Attachment #112857 - Flags: review?(shliang)
Comment on attachment 112857 [details] [diff] [review] Proposed patch sr=alecf
Attachment #112857 - Flags: superreview?(alecf) → superreview+
Attachment #112857 - Flags: review?(shliang) → review+
Comment on attachment 112857 [details] [diff] [review] Proposed patch Not urgent, but it would be nice to get this polish in.
Attachment #112857 - Flags: approval1.3b?
Comment on attachment 112857 [details] [diff] [review] Proposed patch a=asa (on behalf of drivers) for checkin to 1.3beta.
Attachment #112857 - Flags: approval1.3b? → approval1.3b+
Fix checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
verified code fix
Status: RESOLVED → VERIFIED
QA Contact: sujay → gbush
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: