1909566 - [armhf linux] Error: pixman-arm-simd-asm.h:823: Error: garbage following instruction -- `bne 01f'

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mike Hommey [:glandium]]

The build fails when targeting armhf linux and using the latest binutils version, with the following:

pixman-arm-simd-asm.h:823: Error: garbage following instruction -- `bne 01f'
pixman-arm-simd-asm.h:871:  Info: macro invoked from here
pixman-arm-simd-asm.h:326:   Info: macro invoked from here
pixman-arm-simd-asm.h:343:    Info: macro invoked from here
pixman-arm-simd-asm.h:354:     Info: macro invoked from here
pixman-arm-simd-asm.h:408:      Info: macro invoked from here
pixman-arm-simd-asm.h:793:       Info: macro invoked from here
pixman-arm-simd-asm.S:877:        Info: macro invoked from here
pixman-arm-simd-asm.h:824: Error: garbage following instruction -- `bcc 03f'
pixman-arm-simd-asm.h:871:  Info: macro invoked from here
pixman-arm-simd-asm.h:326:   Info: macro invoked from here
pixman-arm-simd-asm.h:343:    Info: macro invoked from here
pixman-arm-simd-asm.h:354:     Info: macro invoked from here
pixman-arm-simd-asm.h:408:      Info: macro invoked from here
pixman-arm-simd-asm.h:793:       Info: macro invoked from here
pixman-arm-simd-asm.S:877:        Info: macro invoked from here

etc.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1909566 - pixman: Adjust arm assembly for binutils change.

A change in the latest version of binutils broke building pixman for arm.

The binutils change:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=226749d5a6ff0d5c607d6428d6c81e1e7e7a994b

This change was committed upstream in
https://gitlab.freedesktop.org/pixman/pixman/-/commit/865e6ce00bb79a6b925ed4c2c436e1533e4472aa
and will be in the next release.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59a698f09c71
pixman: Adjust arm assembly for binutils change. r=gfx-reviewers,lsalzman

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1909566 - pixman: Adjust arm assembly for binutils change.

A change in the latest version of binutils broke building pixman for arm.

The binutils change:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=226749d5a6ff0d5c607d6428d6c81e1e7e7a994b

This change was committed upstream in
https://gitlab.freedesktop.org/pixman/pixman/-/commit/865e6ce00bb79a6b925ed4c2c436e1533e4472aa
and will be in the next release.

Original Revision: https://phabricator.services.mozilla.com/D217517

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1909566 - pixman: Adjust arm assembly for binutils change.

A change in the latest version of binutils broke building pixman for arm.

The binutils change:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=226749d5a6ff0d5c607d6428d6c81e1e7e7a994b

This change was committed upstream in
https://gitlab.freedesktop.org/pixman/pixman/-/commit/865e6ce00bb79a6b925ed4c2c436e1533e4472aa
and will be in the next release.

Original Revision: https://phabricator.services.mozilla.com/D217517

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1909566 - pixman: Adjust arm assembly for binutils change.

A change in the latest version of binutils broke building pixman for arm.

The binutils change:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=226749d5a6ff0d5c607d6428d6c81e1e7e7a994b

This change was committed upstream in
https://gitlab.freedesktop.org/pixman/pixman/-/commit/865e6ce00bb79a6b925ed4c2c436e1533e4472aa
and will be in the next release.

Original Revision: https://phabricator.services.mozilla.com/D217517

Comment 6

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Build failure on armhf linux with latest binutils
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: trivial relabelling
• String changes made/needed: N/A
• Is Android affected?: no

Comment 7

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Build failure on armhf linux with latest binutils
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: Trivial relabelling
• String changes made/needed: N/A
• Is Android affected?: no

Comment 8

[Phabricator Automation]

esr115 Uplift Approval Request

• User impact if declined: Build failure on armhf linux with latest binutils
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: Trivial relabelling
• String changes made/needed: N/A
• Is Android affected?: no

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/59a698f09c71

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/c59993476142

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/95dce030f342

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/ac053f4f561a