1909587 - [mips64] Failed to build (error: could not convert ‘js::jit::ABIType::Float64’ from ‘js::jit::ABIType’ to ‘int’))

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P1)

Description

[Jiaxun Yang [:flygoat]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0

Steps to reproduce:

Build Firefox on MIPS64 system

Actual results:

Error:

In file included from Unified_cpp_js_src_jit15.cpp:29: 
/var/cache/acbs/build/acbs.qgwua8gz/firefox-128.0/js/src/jit/mips64/MoveEmitter-mips64.cpp: In member function ‘virtual void js::jit::MoveEmitterMIPS64::breakCycle(const js::jit::MoveOperand&, const js::jit::MoveOperand&, js::jit::MoveOp::Type, uint32_t)’: 
/var/cache/acbs/build/acbs.qgwua8gz/firefox-128.0/js/src/jit/mips64/MoveEmitter-mips64.cpp:33:19: error: could not convert ‘js::jit::ABIType::Float64’ from ‘js::jit::ABIType’ to ‘int’ 
   33 |     case ABIType::Float64: 
      |          ~~~~~~~~~^~~~~~~ 
      |          | 
      |          js::jit::ABIType 
/var/cache/acbs/build/acbs.qgwua8gz/firefox-128.0/js/src/jit/mips64/MoveEmitter-mips64.cpp: In member function ‘virtual void js::jit::MoveEmitterMIPS64::completeCycle(const js::jit::MoveOperand&, const js::jit::MoveOperand&, js::jit::MoveOp::Type, uint32_t)’: 
/var/cache/acbs/build/acbs.qgwua8gz/firefox-128.0/js/src/jit/mips64/MoveEmitter-mips64.cpp:88:19: error: could not convert ‘js::jit::ABIType::Float64’ from ‘js::jit::ABIType’ to ‘int’ 
   88 |     case ABIType::Float64: 
      |          ~~~~~~~~~^~~~~~~ 
      |          | 
      |          js::jit::ABIType 

Expected results:

Build works.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::JavaScript Engine: JIT' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Jiaxun Yang [:flygoat]]

I'll try to submit a patch.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:iain, since you are the author of the regressor, bug 1870747, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Jiaxun Yang [:flygoat]]

Attachment: Bug 1909587: Correct MoveEmitter switch case r=rhunt!

This seems to be a accidental change made in D198105.

Signed-off-by: Jiaxun Yang <[e-mail]>

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1870747

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/748ea606fb5e
Correct MoveEmitter switch case r=rhunt

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/748ea606fb5e

Comment 8

[Jiaxun Yang [:flygoat]]

Attachment: Bug 1909587: Correct MoveEmitter switch case r=rhunt!

This seems to be a accidental change made in D198105.

Signed-off-by: Jiaxun Yang <[e-mail]>

Original Revision: https://phabricator.services.mozilla.com/D217671

Comment 9

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: FTBFS for MIPS64 platform
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Build on MIPS64 platform
• Risk associated with taking this patch: N/A
• Explanation of risk level: No Tier 1 platform is touched
• String changes made/needed: No
• Is Android affected?: no

Comment 10

[Jiaxun Yang [:flygoat]]

Attachment: Bug 1909587: Correct MoveEmitter switch case r=rhunt!

This seems to be a accidental change made in D198105.

Signed-off-by: Jiaxun Yang <[e-mail]>

Original Revision: https://phabricator.services.mozilla.com/D217671

Comment 11

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: FTBFS for MIPS64 platform
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Build on MIPS64 platform
• Risk associated with taking this patch: N/A
• Explanation of risk level: No Tier 1 platform is touched
• String changes made/needed: No
• Is Android affected?: no

Comment 12

[Jiaxun Yang [:flygoat]]

Attachment: Bug 1909587: Correct MoveEmitter switch case r=rhunt!

This seems to be a accidental change made in D198105.

Signed-off-by: Jiaxun Yang <[e-mail]>

Original Revision: https://phabricator.services.mozilla.com/D217671

Comment 13

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: FTBFS for MIPS64 platform
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Build on MIPS64 platform
• Risk associated with taking this patch: N/A
• Explanation of risk level: No Tier 1 platform is touched
• String changes made/needed: No
• Is Android affected?: no

Comment 14

[Donal Meehan [:dmeehan]]

Comment on attachment 9417253 [details]
Bug 1909587: Correct MoveEmitter switch case r=rhunt!

Rejecting uplift request, S3 bug introduced in Fx123. This will ride the train to release with Fx130.

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/3f5a6d063dd0