1909752 - Perma [tier 2] toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js | Interactive elements must be labeled: id: moz-toggle-button, tagName: BUTTON, className: toggle-button

Status: RESOLVED DUPLICATE of bug 1909712

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=467797044&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/GltrTbLCR5ySngJWbSvVYQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2024-07-24T21:17:28.049Z] 21:17:28     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js | There is no l10n name - 
[task 2024-07-24T21:17:28.050Z] 21:17:28     INFO - Buffered messages finished
[task 2024-07-24T21:17:28.052Z] 21:17:28     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js | Interactive elements must be labeled: id: moz-toggle-button, tagName: BUTTON, className: toggle-button - 
[task 2024-07-24T21:17:28.053Z] 21:17:28     INFO - Stack trace:
[task 2024-07-24T21:17:28.053Z] 21:17:28     INFO - chrome://mochikit/content/browser-test.js:test_ok:1597
[task 2024-07-24T21:17:28.054Z] 21:17:28     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:752
[task 2024-07-24T21:17:28.054Z] 21:17:28     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertLabelled:966
[task 2024-07-24T21:17:28.054Z] 21:17:28     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertLabelled/<:946
[task 2024-07-24T21:17:28.055Z] 21:17:28     INFO - EventListener.handleEvent*chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertLabelled:927
[task 2024-07-24T21:17:28.055Z] 21:17:28     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:1173
[task 2024-07-24T21:17:28.056Z] 21:17:28     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:1137
[task 2024-07-24T21:17:28.056Z] 21:17:28     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleEvent:1254
[task 2024-07-24T21:17:28.056Z] 21:17:28     INFO - chrome://global/content/elements/moz-toggle.mjs:click:61
[task 2024-07-24T21:17:28.057Z] 21:17:28     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js:testDetailOperations:446
[task 2024-07-24T21:17:28.057Z] 21:17:28     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-07-24T21:17:28.057Z] 21:17:28     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-07-24T21:17:28.058Z] 21:17:28     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-07-24T21:17:28.058Z] 21:17:28     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-07-24T21:17:28.059Z] 21:17:28     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-07-24T21:17:28.062Z] 21:17:28     INFO - Console message: 1721855847504	addons.xpi	DEBUG	Updating XPIState for {"id":"[e-mail]","syncGUID":"{b2b1d724-ca08-4e0e-bda5-d4cb66439be1}","version":"1.0","type":"extension","loader":null,"updateURL":null,"installOrigins":null,"manifestVersion":2,"optionsURL":null,"optionsType":null,"optionsBrowserStyle":true,"aboutURL":null,"defaultLocale":{"name":"Test","creator":null,"developers":null,"translators":null,"contributors":null},"visible":true,"active":true,"userDisabled":true,"appDisabled":false,"embedderDisabled":false,"installDate":1721855847191,"updateDate":1721855847181,"applyBackgroundUpdates":1,"path":"/tmp/generated-extension.xpi","skinnable":false,"sourceURI":null,"releaseNotesURI":null,"softDisabled":false,"foreignInstall":false,"strictCompatibility":true,"locales":[],"targetApplications":[{"id":"[e-mail]","minVersion":null,"maxVersion":null}],"targetPlatforms":[],"signedState":0,"signedTypes":[],"signedDate":null,"seen":true,"dependencies":[],"incognito":"spanning","userPermissions":{"permissions":[],"origins":[]},"optionalPermissions":{"permissions":[],"origins":[]},"requestedPermissions":{"permissions":[],"origins":[]},"icons":{},"iconURL":null,"blocklistState":0,"blocklistURL":null,"startupData":null,"hidden":false,"installTelemetryInfo":null,"recommendationState":null,"rootURI":"jar:file:///tmp/generated-extension.xpi!/","location":"app-temporary"}
[task 2024-07-24T21:17:28.064Z] 21:17:28     INFO - Console message: 1721855847504	addons.xpi-utils	DEBUG	Updating active state for add-on [e-mail] to false
[task 2024-07-24T21:17:28.065Z] 21:17:28     INFO - Console message: 1721855847505	addons.xpi	DEBUG	Calling bootstrap method shutdown on [e-mail] version 1.0
[task 2024-07-24T21:17:28.066Z] 21:17:28     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js | The name is updated to the disabled text

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1909048

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Anna, my patch changed requestAnimationFrame timing. Do you know how that could impact this a11y-checks bit?

Also, how do I run this locally?

My guess is that at the point we're doing the check the element is not yet localized (so we should probably wait till that's the case).

Comment 3

[Anna Yeddi [:ayeddi]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Anna, my patch changed requestAnimationFrame timing. Do you know how that could impact this a11y-checks bit?

Also, how do I run this locally?

My guess is that at the point we're doing the check the element is not yet localized (so we should probably wait till that's the case).

Oh, I think your guess is the most likely scenario: Fluent is async while the AccessibilityUtils are running synchronously, so waiting for the label mutation is probably going to fix the issue.

You could run a11y tests locally with --enable-a11y-checks flag in your ./mach test command (more).

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1909752 - Allow intermediate ancestors between focused radiogroup and radio. r=#settings-reviewers,#theme

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cb637ae0e9c
Allow intermediate ancestors between focused radiogroup and radio. r=desktop-theme-reviewers,dao

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7cb637ae0e9c

Comment 7

[Emilio Cobos Álvarez (:emilio)]

That patch was for bug 1909671, sorry for the mess.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

But actually this bug was fixed by bug 1909712.

Comment 9

[Phabricator Automation]

Comment on attachment 9416259 [details]
Bug 1909752 - Allow intermediate ancestors between focused radiogroup and radio. r=#settings-reviewers,#theme

Revision D217808 was moved to bug 1909671. Setting attachment 9416259 [details] to obsolete.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/d95456aa9e77

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/0c6933784ece