1909793 - [mips64] MacroAssembler::move8ZeroExtend unimplemented

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Jiaxun Yang [:flygoat]]

Steps to reproduce:

Build js

Actual results:

Build failure due to MacroAssembler::move8ZeroExtend unimplemented

Expected results:

Build successful.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::JavaScript Engine' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:anba, since you are the author of the regressor, bug 1873042, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Jiaxun Yang [:flygoat]]

Attachment: Bug 1909793: Implement MacroAssembler::move8ZeroExtend for mips r=jandem!

Port D197690 for MIPS.

Signed-off-by: Jiaxun Yang <[e-mail]>

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1873042

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0de774579c66
Implement MacroAssembler::move8ZeroExtend for mips r=jandem

Comment 6

[Jiaxun Yang [:flygoat]]

Attachment: Bug 1909793: Implement MacroAssembler::move8ZeroExtend for mips r=jandem!

Port D197690 for MIPS.

Signed-off-by: Jiaxun Yang <[e-mail]>

Original Revision: https://phabricator.services.mozilla.com/D217672

Comment 7

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Faild to build from source on MIPS64 platform
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: ./mach build for MIPS64
• Risk associated with taking this patch: N/A
• Explanation of risk level: Didn't touch any official supported platform
• String changes made/needed: No
• Is Android affected?: no

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/0de774579c66

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:flygoat, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Jiaxun Yang [:flygoat]]

Attachment: Bug 1909793: Implement MacroAssembler::move8ZeroExtend for mips r=jandem!

Port D197690 for MIPS.

Signed-off-by: Jiaxun Yang <[e-mail]>

Original Revision: https://phabricator.services.mozilla.com/D217672

Comment 11

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Faild to build from source on MIPS64 platform
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: ./mach build for MIPS64
• Risk associated with taking this patch: N/A
• Explanation of risk level: Didn't touch any official supported platform
• String changes made/needed: No
• Is Android affected?: no

Comment 12

[Jiaxun Yang [:flygoat]]

Nominate for beta to keep source buildable for downstream distros on MIPS64.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/561a4fc91d27

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/1fb051404133