1909798 - Large dependency graphs do not work

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[:glob ✱]

View a large dependency graph such as https://bugzilla.mozilla.org/showdependencygraph.cgi?display=web&rankdir=LR&showsummary=on&id=1753933

Thanks to bug 1906996 it no longer times out, however it also doesn't generate a graph.

Instead there's a maroon blob in the top-left corner of the page and a javascript error:

Uncaught (in promise) Error: Parse error on line 416:
...-painting-fl°°91¶ß003|004fl°°93¶ß.html]) -
-----------------------^
Expecting 'STADIUMEND', 'TAGEND', 'UNICODE_TEXT', 'TEXT', 'TAGSTART', got 'PIPE'
    parseError https://bugzilla.mozilla.org/static/v20240724.1/js/lib/mermaid.min.js:359
    parse https://bugzilla.mozilla.org/static/v20240724.1/js/lib/mermaid.min.js:361
    parse https://bugzilla.mozilla.org/static/v20240724.1/js/lib/mermaid.min.js:65
    c$e https://bugzilla.mozilla.org/static/v20240724.1/js/lib/mermaid.min.js:65
    Rjt https://bugzilla.mozilla.org/static/v20240724.1/js/lib/mermaid.min.js:65

I've seen this on multiple bugs.

Comment 1

[David Lawrence [:dkl]]

Seems that I also need to escape '|' characters as well which have meaning to Mermaid. If you look at the debug text using https://bugzilla.mozilla.org/showdependencygraph.cgi?display=web&rankdir=LR&showsummary=on&id=1753933&debug=1 then the following line(s) seem to be causing the crash.

1887366([1887366<br>NEW  Failing WPT css/css-pseudo/highlight-painting-#91;003|004#93;.html]) --> 1703963([1703963<br>NEW  Implement CSS-Pseudo-4 #34;highlight selectors#34;])

I will add this to mermaid_quote()

Comment 2

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1909798 - Large dependency graphs do not work (#2283)

Comment 3

[David Lawrence [:dkl]]

I have pushed the latest fixes in this PR to bugzilla-dev for testing. Here is the original bug causing the breakage in its full, practically unreadable glory. Hopefully most dependency trees will not be this large.

https://bugzilla-dev.allizom.org/showdependencygraph.cgi?display=web&rankdir=LR&showsummary=on&id=1753933

Comment 4

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/6270f7864a431f3b112688fc66a3ca6f600d2fc4