1909832 - User namespaces warning appears in about:support on flatpak despite not being relevant or actionable

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Kestrel]

Attachment: about:support warning regarding user namespaces on flatpak

Bug 1909616 suppressed the user namespaces warning message on flatpak but there is still a warning in about:support which is not relevant and confusing:

This feature is not allowed by your system. This can restrict security features of Nightly. Learn more.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:gerard-majax, since you are the author of the regressor, bug 1899516, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[:gerard-majax]

This is not a regression from bug 1899516 but from bug 1900439

Comment 4

[:gerard-majax]

Probably we should just not show the message about the feature being a risk for Flatpak, similar to bug 1909616

Comment 5

[Brian Tsoi [:btsoi]]

Attachment: Bug 1909832 - Do not show userns warning in about:support on Flatpak/Snap/Deb r?gcp!,gerard-majax!

Comment 6

[Brian Tsoi [:btsoi]]

Comment on attachment 9414861 [details]
Bug 1909832 - Do not show userns warning in about:support on Flatpak/Snap/Deb r?gcp!,gerard-majax!

Beta/Release Uplift Approval Request

• User impact if declined: Incorrect warning in about:support of reduced security of the sandbox
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1909616
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): At worst we would not be showing the warning at all. The fix only relies on pre-existing code that sources the information of whether we are running as a Packaged App (Flatpak/Snap/Deb) and avoids showing the warning if it's the case. Impact is limited to Flatpak
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9414861 [details]
Bug 1909832 - Do not show userns warning in about:support on Flatpak/Snap/Deb r?gcp!,gerard-majax!

Rejecting beta uplift since Fx129 is now in release and this hasn't landed yet.
Please submit a release uplift request if you want to ride along in a dot release.

Comment 8

[Donal Meehan [:dmeehan]]

:bstoi the Fx130 soft code freeze starts on Thursday 2024-08-01.
Please land this when ready so it will at least ride the train with Fx130.

Comment 9

[Brian Tsoi [:btsoi]]

Got it. I don't have level 3 access but I'll get someone to land it for me.

Comment 10

[:gerard-majax]

my bad, brian asked me yesterday and i missed his message, it's pushed

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/067d9b2ba48c
Do not show userns warning in about:support on Flatpak/Snap/Deb r=gcp,gerard-majax

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/067d9b2ba48c