1909892 - www.dropbox.com - Unable to upload files

Status: NEW

(Web Compatibility :: Site Reports, defect, P1)

Description

[Calin Tanase (OOO until 22nd of Nov)]

Environment:
Operating system: Android 11
Firefox version: Firefox Mobile [phone]

Steps to reproduce:

1. Go to https://www.dropbox.com
2. Log into your account.
3. Tap on "Upload" and then on "File".
4. Upload any file.
5. Observe the behavior.

Expected Behavior:
The file gets uploaded.

Actual Behavior:
The file is stuck in queue.

Notes:

• Reproduces regardless of the status of ETP
• Reproduces in Firefox Nightly, and Firefox Release
• Does not reproduce in Chrome

Created from https://github.com/webcompat/web-bugs/issues/139564

Comment 1

[Calin Tanase (OOO until 22nd of Nov)]

Attachment: dropbox upload FF vs Chrome.mp4

Comment 2

[Jeff Muizelaar [:jrmuizel]]

In Chrome, uploading happens via POST to https://www.dropbox.com/2/files/upload_session/append_v2 which happens after https://www.dropbox.com/cmd/upload_precheck

Comment 3

[Jeff Muizelaar [:jrmuizel]]

We get this far and it looks like isWebkitFile is false which causes us to not get much further:

              this.uploadLocalFiles = async() => {
                const t = this.itemsAsList.filter(
                  (
                    t => t.source === s.FileSource.Computer &&
                    !t.isDir &&
                    t.file &&
                    - 1 !== Q.indexOf(t.status)
                  )
                );
                for (const e of t) e.file &&
                s.isWebkitFile(e.file) &&
                (
                  this.scheduler.addFile(e.file, e.destPath, e, e.contentEncryptionInfo),
                  e.status = s.UploadStatus.Queued,
                  e.bytesUploaded = 0,
                  this.updateParentStatus(e)
                );
                this.isStopped = !1,
                this.notifyAll(),
                await this.scheduler.startUploading(),
                this.notifyAll()

isWebkitFile looks something like: e => 'webkitRelativePath' in e

Comment 4

[Jeff Muizelaar [:jrmuizel]]

webkitRelativePath is not exposed on Android because:

- name: dom.webkitBlink.dirPicker.enabled
  type: RelaxedAtomicBool
  value: @IS_NOT_ANDROID@
  mirror: always

Comment 5

[Jeff Muizelaar [:jrmuizel]]

setting dom.webkitBlink.dirPicker.enabled=true makes uploading work

Comment 6

[Jeff Muizelaar [:jrmuizel]]

dom.webkitBlink.dirPicker.enabled has always been disabled on Android: https://hg.mozilla.org/mozilla-central/rev/5785e6e80c66

Smaug, do you know why?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

baku might recall. (Was it that there isn't/wasn't a good file picker or what on Android?)

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Baku said he doesn't remember. I'll investigate.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

<input type=file webkitdirectory> is definitely not working on Android when enabled, but it is not really working on mobile Chrome either.
Need to do some more testing.

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

There's logging under "FilePickerDelegate" which may help:

const { debug, warn } = GeckoViewUtils.initLogging("FilePickerDelegate");

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Aha, https://searchfox.org/mozilla-central/rev/6e6265bd607cbe4c96e714f86d3d9e36620f63d6/mobile/shared/components/geckoview/FilePickerDelegate.sys.mjs#20,23
That is why https://mozilla.pettay.fi/moztests/webkitdirectory.html can't work even if the pref is enabled.

Comment 12

[Makoto Kato [:m_kato]]

I guess that GeckoView side have to design delegate API (bug 1674428).