Closed Bug 1910100 Opened 11 months ago Closed 11 months ago

Make sure we pass the model revision

Categories

(Core :: Machine Learning, defect)

Product:
Core
Component:
Machine Learning
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed

People

(Reporter: tarek, Assigned: tarek)

Details

Attachments

(1 file)

Bug 1910100 - Make sure we pass the model revision r?atossou
48 bytes, text/x-phabricator-request
Details | Review

I found two bugs:

  • tried to use the v0.2 of the model and realized we don't pass the revision to ONNX
  • when the model exists in RS, if we try to overwrite the modelRevision, it still picks the one in RS
Pushed by tziade@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65dd05740c4a Make sure we pass the model revision r=atossou

Backed out for causing mochitest failures on browser_aboutinference.js

Backout link

Push with failures

Failure log

Flags: needinfo?(tziade)

oops sorry I forgot to update one test. done

Flags: needinfo?(tziade)
Pushed by tziade@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6d8f9e19c655 Make sure we pass the model revision r=atossou

https://hg.mozilla.org/mozilla-central/rev/6d8f9e19c655

Status: NEW → RESOLVED
Closed: 11 months ago
status-firefox130: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: