1910155 - Clicking a link on a web page should always change the URL in the address bar

Status: REOPENED

(Firefox :: Address Bar, defect, P2)

Description

[Mike Kaply [:mkaply]]

If you go to a page like yahoo.com, then click in the URL bar and start to edit the URL, and then click on link on the web page, the URL bar stays as the URL that you started editing.

The URL should update when the new page is loaded.

This is inconsistent with how other browser work.

It also feels like this is a potential vector for phishing, as you can't see the URL pages that you are navigating to when you are in this state, so someone could get you to start editing the URL and then have you click links to navigate to a bad site.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3f585af46d397f19019f4c8d0eb53b546d532d20&tochange=a2e37e6c3ef6f40e27476400eec9d46fc65b0d89

Suspect: a982595313dd6271a23b5798e2bbebf9128e7f55 Neil Deakin — Bug 1598919, move Browser:LoadURI into BrowserTabParent actor, r=mconley

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1598919

:enndeakin, since you are the author of the regressor, bug 1598919, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Mike Kaply [:mkaply]]

Thank you for this info!

Comment 4

[Alice0775 White]

I think this is not a duplication of the Bug 1754954 because Bug 1754954 is reproduced even on the good build of comment#1.

Comment 5

[Alice0775 White]

Steps to reproduce:

1. Open https://www.yahoo.com/
2. Edit text in address bar
3. Click a link (e.g. a link in section Stories for you)

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[Marco Bonardo [:mak]]

I can confirm steps in comment 5, and that this should be addressed apart from Bug 1754954.

I'm not sure why bug 1598919 matters yet, the code changed a lot from then. setURI is invoked in all the cases, both here and for Bug 1754954, though setURI tries to preserve userTypedValue as far as possible, maybe before we were unsetting userTypedValue?

Overall we may want to change the behavior, acting more similarly to other browsers.
We could always restore the url and blur the urlbar unless the typed value changes between load start and load end (to avoid Bug 1645648).