1910168 - Repairing a local folder makes all the messages disappear from view (re-appear when you revisit the folder)

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Francesco]

I tried this in 129.0b5 (64-bit). STR:

• Have a folder with some messages
• Move a message to another folder
• Repair the source folder

Result: The message list is empty. Console shows:

Uncaught : Component returned failure code: 0x80550005 [nsIMsgFolder.updateFolder]
    updateFolderAndNotifyOnLoad resource:///modules/DBViewWrapper.sys.mjs:111
    open resource:///modules/DBViewWrapper.sys.mjs:844
    _onSelect chrome://messenger/content/about3Pane.js:2738
    handleEvent chrome://messenger/content/about3Pane.js:1710
    rebuildSummary chrome://messenger/content/about3Pane.js:3410
    RebuildSummaryInformation chrome://messenger/content/folderProps.js:482
    oncommand chrome://messenger/content/folderProps.xhtml:1
    editFolder chrome://messenger/content/about3Pane.js:3416
    <anonymous> chrome://messenger/content/about3Pane.js:6304
    doCommand chrome://messenger/content/mailCommon.js:744
    triggerCommand chrome://messenger/content/about3Pane.js:855
    onCommand chrome://messenger/content/about3Pane.js:839
    handleEvent chrome://messenger/content/about3Pane.js:326

Looks a bit like bug 1831190.

Comment 1

[Francesco]

This happens on 115, too, the JS stack is similar.

Comment 2

[Wayne Mery (:wsmwk)]

Presumably this also affects 128.

Comment 3

[Magnus Melin [:mkmelin]]

0x80550005 is NS_MSG_ERROR_FOLDER_SUMMARY_OUT_OF_DATE, which rebuilding should have fixed...
I can confirm the bug. Pretty sure bug 1831190 did work at the time though.

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1910168 - Fix refreshing the view after a folder has been repaired. r=mkmelin

Comment 5

[Wayne Mery (:wsmwk)]

nice!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/278bf64e99d7
Fix refreshing the view after a folder has been repaired. r=mkmelin

Comment 8

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9417993 [details]
Bug 1910168 - Fix refreshing the view after a folder has been repaired. r=mkmelin

[Approval Request Comment]
User impact if declined: Repairing a local folder makes all the messages disappear from view (re-appear when you revisit the folder)
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): Fairly low. Should be uplifted together with Bug 1913224.

Comment 9

[Corey Bryant]

Comment on attachment 9417993 [details]
Bug 1910168 - Fix refreshing the view after a folder has been repaired. r=mkmelin

[Triage Comment]
Approved for esr128

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 128.2.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/75ff2ad4a620