1910354 - Custom tabs have no opening and closing animation

Status: VERIFIED FIXED

(Firefox for Android :: Tabs, enhancement)

Description

[[:coin3x]]

Attachment: Screen recording of Firefox

Steps to reproduce:

1. Set the default browser to Firefox so that custom tabs opens in Firefox.
2. Open the Gmail app and click on any link to open a custom tab.
3. Observe the transition between the Gmail app and Firefox.

Actual results:

Unlike Chrome (see attached screen recordings), there are no animation when I open the link and navigate back.

Expected results:

There should be animation.

Comment 1

[[:coin3x]]

Attachment: Screen recording of Chrome

Comment 2

[[:coin3x]]

Attachment: Bug 1910354 - Inherit window animation attributes from the framework. r?#android-reviewers

WindowAnimationTransition specifies only the enter and exit window
animation. When a user launches a custom tab, Android animates both the
originating activity and the custom tab one using the animation from
attributes like android:activityOpenEnterAnimation, which, are not set
here and will be resolved to null at runtime. This prevents the system
from animating the opening and closing of custom tabs.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Thank you for raising this!
Unfortunately it's a known situation that we don't yet have a UX approval for.
Will check again if we want to change the transitions.

Comment 4

[[:coin3x]]

Rather than to have no transitions at all, would it be preferable to use default transitions first while the team evaluates whether to have custom transitions?

Comment 5

[Petru-Mugurel Lingurar [:petru]]

@coin3x
Even using the default transitions is a change which would impact app's behaviour for users so it needs to be acknowledged/approved before landing.
Asked about your proposal and will update here/in the PR when we have a clear response.

Comment 7

[Petru-Mugurel Lingurar [:petru]]

@coin3x
Thank you for working on this!
Improving animations is something planned for Fenix and this animation in particular can change later but for now this is an improvement that would benefit users so it's okay to land.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98cce1857179
Inherit window animation attributes from the framework. r=android-reviewers,petru

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/98cce1857179

Comment 10

[Mira Lobontiu (Android QA)]

Verified as implemented on the Fenix Nightly 131.0a1 build from 8/6.
Tested with Google Pixel 6 (Android 15), and Samsung Galaxy A14 (Android 13).