1910472 - Wrong calendar name and colour are shown when adding a remote calendar

Status: NEW

(Calendar :: Dialogs, defect)

Description

[Tristan Miller]

When adding a calendar from a remote location that supports multiple calendar types, the user has the opportunity to specify a name and colour for the calendar via a separate "Edit Calendar" dialog. Confusingly, this new name and colour is not reflected in the "Create New Calendar" dialog.

Steps to reproduce:

1. File -> New -> Calendar. A "Create New Calendar" dialog appears.
2. Select "On the network" and press "Next".
3. Enter a username and location for a remote calendar and press "Find Calendars".
4. If an "Authentication Required" dialog appears, enter the password and press "OK".
5. The dialog indicates that multiple calendar types are available. A list of calendars with default names and colours is displayed. Press the "Properties" button next to one. An "Edit Calendar" dialog appears.
6. Change the calendar name and colour and press OK. The "Edit Calendar" dialog disappears.

Observed behaviour:

• The "Create New Calendar" dialog still shows the old calendar name and colour.

Expected behaviour:

• The "Create New Calendar" dialog should show the new calendar name and colour.

Comment 2

[Tobias (:Tobbi) Markus]

I believe that the culprit is these lines here:
https://github.com/mozilla/releases-comm-central/blob/87b8eb11d1cb9c60c1a9196348e0d94b31e8f5ca/calendar/base/content/dialogs/calendar-creation.js#L829-L832

There, the item gets updated as soon as the settings button is clicked. Ideally, we want a callback for the child dialog's closed event or something similar.

Alternatively, we could add an event listener for the parent dialog's onfocus event that will occur after the child dialog gets closed.