1910494 - TEST-UNEXPECTED-FAIL | test262/intl402/Temporal/PlainDate/prototype/with/cross-era-boundary.js

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect)

Description

[Mike Hommey [:glandium]]

When upgrading to rustc 1.80:

[task 2024-07-29T21:00:28.270Z] ## test262/intl402/Temporal/PlainDate/prototype/with/cross-era-boundary.js: rc = 3, run time = 0.045518
[task 2024-07-29T21:00:28.270Z] /builds/worker/checkouts/gecko/js/src/tests/test262/intl402/Temporal/PlainDate/prototype/with/cross-era-boundary.js:14:26 Error: internal error while computing calendar data
[task 2024-07-29T21:00:28.270Z] Stack:
[task 2024-07-29T21:00:28.270Z]   @/builds/worker/checkouts/gecko/js/src/tests/test262/intl402/Temporal/PlainDate/prototype/with/cross-era-boundary.js:14:26
[task 2024-07-29T21:00:28.270Z] TEST-UNEXPECTED-FAIL | test262/intl402/Temporal/PlainDate/prototype/with/cross-era-boundary.js | (args: "--dll /builds/worker/fetches/injector/libbreakpadinjector.so") [0.0 s]

This is caused by https://github.com/unicode-org/icu4x/issues/5039

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1910494 - Upgrade zerovec to 0.10.4.

Comment 2

[Mike Hommey [:glandium]]

Is the segmenter exposed to content on 128?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e13a477e3cb
Upgrade zerovec to 0.10.4. r=supply-chain-reviewers

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Mike Hommey [:glandium] from comment #2)

Is the segmenter exposed to content on 128?

Intl.Segmenter is already shipped, but this error seems to be Temporal.

anba, Temporal isn't shipped on stable yet, right?

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9e13a477e3cb

Comment 6

[Mike Hommey [:glandium]]

(In reply to Makoto Kato [:m_kato] from comment #4)

(In reply to Mike Hommey [:glandium] from comment #2)

Is the segmenter exposed to content on 128?

Intl.Segmenter is already shipped, but this error seems to be Temporal.

The Segmenter seems to be using zerovec, though. We're not seeing problems in tests, but I can't guarantee it actually doesn't do bad things.

Comment 7

[André Bargull [:anba]]

(In reply to Makoto Kato [:m_kato] from comment #4)

anba, Temporal isn't shipped on stable yet, right?

Correct. Temporal requires the configure flag --with-temporal-api to be set, which isn't yet enabled by default.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:glandium, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Makoto Kato [:m_kato]]

(In reply to Mike Hommey [:glandium] from comment #6)

The Segmenter seems to be using zerovec, though. We're not seeing problems in tests, but I can't guarantee it actually doesn't do bad things.

zerovec is used on ICU4X data marker, so it doesn't depends on segmenter only. Currently, I guess that we already use ICU4X for bidi, normalization of URL and etc

Comment 10

[Mike Hommey [:glandium]]

Ok, so this would need to be uplifted to ESR too... except ESR doesn't have bug 1899411, which updated zerovec from 0.10.1 to 0.10.2

Comment 11

[Mike Hommey [:glandium]]

Attachment: Bug 1910494 - Upgrade zerovec to 0.10.4.

Original Revision: https://phabricator.services.mozilla.com/D218020

Comment 12

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Undefined behavior when some ICU4X data is used
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: Straightforward addition of an attribute to a few structs
• String changes made/needed: N/A
• Is Android affected?: yes

Comment 13

[Mike Hommey [:glandium]]

Attachment: Bug 1910494 - Upgrade zerovec to 0.10.4.

Original Revision: https://phabricator.services.mozilla.com/D218020

Comment 14

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Undefined behavior when some ICU4X data is used
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: Straightforward addition of an attribute to a few structs
• String changes made/needed: N/A
• Is Android affected?: yes

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/b960fcd2d44e

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/5452020f964d