1910501 - TypeError: 'Task' object is not subscriptable

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Mike Hommey [:glandium]]

Decision tasks are failing on the toolchains project branch with:

[task 2024-07-29T22:08:29.019Z] Traceback (most recent call last):
[task 2024-07-29T22:08:29.019Z]   File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 209, in taskgraph_decision
[task 2024-07-29T22:08:29.019Z]     ret = taskgraph_commands["decision"].func(options)
[task 2024-07-29T22:08:29.019Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/main.py", line 703, in decision
[task 2024-07-29T22:08:29.019Z]     taskgraph_decision(options)
[task 2024-07-29T22:08:29.019Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/decision.py", line 227, in taskgraph_decision
[task 2024-07-29T22:08:29.019Z]     write_artifact("task-graph.json", tgg.morphed_task_graph.to_json())
[task 2024-07-29T22:08:29.019Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 220, in morphed_task_graph
[task 2024-07-29T22:08:29.019Z]     return self._run_until("morphed_task_graph")
[task 2024-07-29T22:08:29.019Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 425, in _run_until
[task 2024-07-29T22:08:29.019Z]     k, v = next(self._run)  # type: ignore
[task 2024-07-29T22:08:29.019Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 399, in _run
[task 2024-07-29T22:08:29.019Z]     optimized_task_graph, label_to_taskid = optimize_task_graph(
[task 2024-07-29T22:08:29.019Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/optimize/base.py", line 94, in optimize_task_graph
[task 2024-07-29T22:08:29.019Z]     replaced_tasks = replace_tasks(
[task 2024-07-29T22:08:29.019Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/optimize/base.py", line 342, in replace_tasks
[task 2024-07-29T22:08:29.019Z]     repl = opt.should_replace_task(task, params, deadline, arg)
[task 2024-07-29T22:08:29.019Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/optimize/strategies.py", line 61, in should_replace_task
[task 2024-07-29T22:08:29.019Z]     f'not replacing {task["label"]} with {task_id} because it expires before {deadline}'
[task 2024-07-29T22:08:29.019Z] TypeError: 'Task' object is not subscriptable

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1909260

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1910501 - Update taskgraph vendor to v10.0.2.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1909260

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89db5fc4da08
Update taskgraph vendor to v10.0.2. r=taskgraph-reviewers,mach-reviewers,bhearsum,ahal

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/89db5fc4da08

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:glandium, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox130 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1910501 - Update taskgraph vendor to v10.0.2.

Original Revision: https://phabricator.services.mozilla.com/D218586

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Possible decision task failures when some tasks expire in the future
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: NPOTB
• String changes made/needed: N/A
• Is Android affected?: no

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5f88fe1960df