1910516 - Crash in [@ operator!=]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[BugBot [:suhaib / :marco/ :calixte]]

Crash report: https://crash-stats.mozilla.org/report/index/7ac2576c-4de8-4736-9ad0-a77e40240725

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0  xul.dll  operator!=  mfbt/RefPtr.h:565
0  xul.dll  mozilla::ClientWebGLContext::GetTexTypeForSwapChain const  dom/canvas/ClientWebGLContext.cpp:471
1  xul.dll  mozilla::ClientWebGLContext::Present  dom/canvas/ClientWebGLContext.cpp:478
1  xul.dll  mozilla::ClientWebGLContext::OnBeforePaintTransaction  dom/canvas/ClientWebGLContext.cpp:459
2  xul.dll  mozilla::layers::ShareableCanvasRenderer::UpdateCompositableClient  gfx/layers/ShareableCanvasRenderer.cpp:182
3  xul.dll  mozilla::layers::WebRenderCanvasRendererAsync::UpdateCompositableClientForEmptyTransaction  gfx/layers/wr/WebRenderCanvasRenderer.cpp:81
3  xul.dll  mozilla::layers::WebRenderCommandBuilder::EmptyTransaction  gfx/layers/wr/WebRenderCommandBuilder.cpp:1743
3  xul.dll  mozilla::layers::WebRenderLayerManager::EndEmptyTransaction  gfx/layers/wr/WebRenderLayerManager.cpp:282
4  xul.dll  mozilla::PresShell::PaintInternal  layout/base/PresShell.cpp:6455
5  xul.dll  mozilla::PresShell::PaintAndRequestComposite  layout/base/PresShell.cpp:6355

By querying Nightly crashes reported within the last 2 months, here are some insights about the signature:

• First crash report: 2024-07-25
• Process type: Content
• Is startup crash: No
• Has user comments: No
• Is null crash: Yes - all crashes happened on null or near null memory address

By analyzing the backtrace, the regression may have been introduced by a patch to fix Bug 1898238.

:jnicol, since you are the author of the potential regressor, could you please take a look?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1898238

Comment 2

[Jamie Nicol [:jnicol] (on leave until 21st October)]

Attachment: Bug 1910516 - Treat webgl context as in-process when determining texture type if context is lost. r?jgilbert

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff2d24637ef5
Treat webgl context as in-process when determining texture type if context is lost. r=jgilbert

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ff2d24637ef5