1910611 - Rename "Moz Button" Storybook story to "Button"

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Hanna Jones [:hjones]]

When the Storybook story for the moz-button component was created we used "Moz Button" as the name in order to distinguish between it and the "Button" story. Since the "Button" story was removed in Bug 1905975 we should rename the "Moz Button" story to just "Button" to keep with our convention of using simple component/element names for story titles.

This should be a simple one line code change - we just need to update the title here.

Instructions on how to get set up running Storybook can be found on the deployed instance of our Storybook site, where the button stories can be previewed as well.

Comment 1

[kasar.hitesh]

I really want to attend to this but I am very new to open source contribution. Your guidance will be highly appreciated.

Comment 2

[Hanna Jones [:hjones]]

Hey :kasar.hitesh thanks for your interest in this bug! To help us out here are some steps you can follow:

1. Download and build the Firefox source code
   • Here is a more detailed tutorial for getting set up to work on Firefox
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
2. Start working on this bug.
   • As outlined above, you just need to change the story title here.
   • If you run into any issues you can comment here and request information from me using the form below to ensure I get notified.
3. Build your change with the ./mach build command and verify your change with the ./mach storybook command. Also check your changes for adherence to our style guidelines by using ./mach lint.
4. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
5. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!

Let me know if you have any more specific questions about the bug.

Comment 3

[Eslam hakem]

Hey :kasar.hitesh are you still work on this issue ?!

Comment 4

[Jess Lark]

Hi :hjones, how long is it appropriate to wait to take a task if it hasn't been worked on?
Also, is there a way to tag people so they get a notification or email?

Thanks!

Comment 5

[Hanna Jones [:hjones]]

Hi Jess - generally if it has been multiple days to weeks and previous commenters haven't responded or submitted a patch it's fair game to work on something. If you want to ping someone directly you can use the form below to request information from them - just fill in their email and the form field should give you autocomplete options.

Comment 6

[Jess Lark]

Thanks Hanna!

Comment 7

[Robert Holdsworth]

Attachment: Bug 1910611 - Rename "Moz Button" Storybook story to "Button" r=hjones

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ddba428afc3
Rename "Moz Button" Storybook story to "Button" r=reusable-components-reviewers,mstriemer

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/2ddba428afc3