1910648 - Remove revampComponentsLoaded from SidebarController

Status: RESOLVED WONTFIX

(Firefox :: Sidebar, task)

Description

[Jonathan Sudiaman [:jsudiaman]]

Once hot-swapping sidebars is working properly, this variable should be synonymous with sidebarRevampEnabled.

Comment 1

[Jonathan Sudiaman [:jsudiaman]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help. This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Firefox Contributors' Quick Reference, which has answers to most development questions.
3. Start working on this bug.
   • The line this.revampComponentsLoaded = true can be removed.
   • Remaining usages of revampComponentsLoaded can be replaced with sidebarRevampEnabled.
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #firefox-view channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach test browser/components/sidebar/tests/. Also check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • Getting your code reviewed
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

Comment 2

[Cassandra]

Hello I would like to contribute. I'll try to work on it.

Comment 3

[Cassandra]

Attachment: Bug 1910648 - Remove revampComponentsLoaded from SidebarController r?Jsudiaman

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/682781dc4c02
https://hg.mozilla.org/integration/autoland/rev/d5f119781422
Remove revampComponentsLoaded from SidebarController r=jsudiaman

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5dabada4ef64
https://hg.mozilla.org/integration/autoland/rev/ea1e811e5a9b
Revert "Bug 1910648 - Remove revampComponentsLoaded from SidebarController r=jsudiaman" for causing bc failures @browser_scroll_size_determination.js.

Comment 6

[agoloman]

Backed out for causing bc failures @browser_scroll_size_determination.js.

• Backout link
• Push with failures
• Failure Log

Comment 7

[Jonathan Sudiaman [:jsudiaman]]

This flag is evidently still needed (would be interesting to figure out why, though...)