1910690 - Update opus to new version 5854a9f7de06ab3505b8fe6e8943db581c2cbe70 from 2024-07-30 11:12:10

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Update Bot]

This update covers 5 commits, including 4 new upstream commits I've never filed a bug on before. (They're the top 4.). Here are the overall diff statistics, and then the commit information.

---

media/libopus/moz.build | 2 +-
media/libopus/moz.yaml | 4 ++--
media/libopus/src/extensions.c | 19 +++++++++----------
media/libopus/src/opus_decoder.c | 13 ++++++++-----
4 files changed, 20 insertions(+), 18 deletions(-)

---

5854a9f7de06ab3505b8fe6e8943db581c2cbe70 by Timothy B. Terriberry <[e-mail]>

https://gitlab.xiph.org/xiph/opus/commit/5854a9f7de06ab3505b8fe6e8943db581c2cbe70
Authored: 2024-07-25 20:19:39 -0700
Committed: 2024-07-30 11:12:10 -0700

Improve extension generator buffer too small test.

Test multiple buffer lengths and ensure we do not write past the
end of the provided buffer.

Files Modified:

• tests/test_opus_extensions.c

---

2ad8669960721cb259e4e28c8e091ffe73a864a0 by Timothy B. Terriberry <[e-mail]>

https://gitlab.xiph.org/xiph/opus/commit/2ad8669960721cb259e4e28c8e091ffe73a864a0
Authored: 2024-07-24 15:58:00 -0700
Committed: 2024-07-30 11:12:10 -0700

Fix type passed to opus_packet_parse_impl().

The function takes an opus_int32 *, but we were passing the address
of an int, which might not be the same.
This is only likely to affect platforms with a 16-bit int.

Files Modified:

• src/opus_decoder.c

---

fe1ab2893ef3619b4a63b69a1608ba54ac49efad by Timothy B. Terriberry <[e-mail]>

https://gitlab.xiph.org/xiph/opus/commit/fe1ab2893ef3619b4a63b69a1608ba54ac49efad
Authored: 2024-07-24 11:42:46 -0700
Committed: 2024-07-30 11:12:10 -0700

Validate frame idx when scanning for DRED payload.

Without this check, a DRED extension encoded with an invalid frame
number would still be used, potentially with a surprisingly large
dred_frame_offset.

Files Modified:

• src/opus_decoder.c

---

a214a46731b1636f8f78582885294145989d60d1 by Timothy B. Terriberry <[e-mail]>

https://gitlab.xiph.org/xiph/opus/commit/a214a46731b1636f8f78582885294145989d60d1
Authored: 2024-07-24 11:36:08 -0700
Committed: 2024-07-30 11:12:10 -0700

Fix overflow and OOB read for large ext lengths.

With an 8+ MB packet it is possible to craft an extension length
that would overflow, bypassing the checks to ensure the extension
data remains inside the packet.
This patch fixes that and adds a test for it.

Files Modified:

• src/extensions.c
• tests/test_opus_extensions.c

---

fc96bb9cc7c59f99b03f8d1225cc708451b8bf45 by Jan Buethe <[e-mail]>

https://gitlab.xiph.org/xiph/opus/commit/fc96bb9cc7c59f99b03f8d1225cc708451b8bf45
Authored: 2024-07-26 12:32:53 +0200
Committed: 2024-07-26 12:32:53 +0200

added osce testing related scripts (ietf120)

Files Added:

• dnn/torch/osce/stndrd/evaluation/commonvoice_clip_selection.py
• dnn/torch/osce/stndrd/evaluation/run_osce_test.py

---

Comment 2

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=95f777bcb760f60f822d4359544d3b460ddc7b99

Comment 3

[Update Bot]

Attachment: Bug 1910690 - Update opus to 5854a9f7de06ab3505b8fe6e8943db581c2cbe70

Comment 4

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Investigation (Possible Intermittents):

• devtools/client/framework/test/browser_toolbox_toggle.js

  • 1 of 4 failed on the same (retriggered) task
    - test-linux1804-64-qr/opt-mochitest-devtools-chrome-5 (ScMUsZUHTOu1ja3gK29mUg)

• devtools/shared/commands/target/tests/browser_target_command_frames.js

  • 1 of 4 failed on the same (retriggered) task
    - test-linux1804-64-qr/debug-mochitest-devtools-chrome-14 (IkLMX8d1Qmi9FypFN_ZAUw)

Known Issues:

• browser/components/extensions/test/browser/browser_ext_devtools_network.js
  - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-4 (XXlvEgpKRxeRrZsmGBsUtQ)

• devtools/shared/commands/target/tests/browser_target_command_service_workers_navigation.js
  - test-macosx1015-64-qr/opt-mochitest-devtools-chrome-5 (cP1lsv0BTW6VlXDpnX4INw)

• netwerk/test/unit/test_websocket_with_h3_active.js
  - test-windows11-32-2009-qr/opt-xpcshell-4 (M417hvfDS_GD-YGDjChCtA)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor media/libopus/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0a0c143ce87
Update opus to 5854a9f7de06ab3505b8fe6e8943db581c2cbe70 r=kinetik

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a0a0c143ce87