1910695 - [wpt-sync] Sync PR 47363 - WebNN: reject buffer reads after destroy

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47363 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47363
Details from upstream follow.

Bryan Bernhart <[e-mail]> wrote:

WebNN: reject buffer reads after destroy

Addresses an issue where readBuffer() may never fulfill its returned promise because the buffer was destroyed. The change avoids this by keeping track of pending resolvers which are always rejected upon disconnection.

Bug: 354055292
Change-Id: I0017d36743673f6d4840f5037f4382f274d9fc45

Reviewed-on: https://chromium-review.googlesource.com/5746505
WPT-Export-Revision: 5c52b7a0c66fcaf482981f27b67eb9d690e8eff2

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d5a4b172747fb55dd98ee911f9e76cff2bc67b3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 32 subtests

Status Summary

Firefox

FAIL : 6
ERROR : 6

Chrome

PASS : 42
FAIL : 12
TIMEOUT: 12
NOTRUN : 132

Safari

FAIL : 6
ERROR : 6

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webnn/conformance_tests/buffer.https.any.worker.html?gpu [wpt.fyi]: ERROR (Chrome: TIMEOUT, Safari: ERROR)
  • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
• /webnn/conformance_tests/buffer.https.any.html?cpu [wpt.fyi]: ERROR (Chrome: TIMEOUT, Safari: ERROR)
  • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
• /webnn/conformance_tests/buffer.https.any.worker.html?cpu [wpt.fyi]: ERROR (Chrome: TIMEOUT, Safari: ERROR)
  • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
• /webnn/conformance_tests/buffer.https.any.html?npu [wpt.fyi]: ERROR (Chrome: TIMEOUT, Safari: ERROR)
  • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
• /webnn/conformance_tests/buffer.https.any.worker.html?npu [wpt.fyi]: ERROR (Chrome: TIMEOUT, Safari: ERROR)
  • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
• /webnn/conformance_tests/buffer.https.any.html?gpu [wpt.fyi]: ERROR (Chrome: TIMEOUT, Safari: ERROR)
  • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d942af270a05
[wpt PR 47363] - WebNN: reject buffer reads after destroy, a=testonly

Comment 4

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/d942af270a05